Mirror syncfs log to console and WebUI, with LogSeverity support.

chrome/browser/sync_file_system/logger_unittest.cc

Index: chrome/browser/sync_file_system/logger_unittest.cc
diff --git a/chrome/browser/sync_file_system/logger_unittest.cc b/chrome/browser/sync_file_system/logger_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..98d615a42b411e340c8234f752b37b6327712e15
--- /dev/null
+++ b/chrome/browser/sync_file_system/logger_unittest.cc
@@ -0,0 +1,57 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/sync_file_system/logger.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using google_apis::EventLogger;
+
+namespace sync_file_system {
+
+namespace {
+
+// Logs one event at each supported LogSeverity level.
+void LogSampleEvents() {
+  util::Log(logging::LOG_INFO, "Info test message");
+  util::Log(logging::LOG_WARNING, "Warning info message");
+  util::Log(logging::LOG_ERROR, "Error info message");

[nhiroki, 2013/05/22 09:18:24]

Can you define these messages as constant? For example,

const char kInfoMessage[] = "Info test message";
const char kWarningMessage[] = "Warning test message";
const char kErrorMessage[] = "Error test message";

And then pass them at line 42-44 and 54.

[calvinlo, 2013/05/23 10:00:15]

Per discussion, it seems like this is not worth doing because of compilation
issues.

+}
+
+}  // namespace
+
+class LoggerTest : public testing::Test {
+ public:
+  LoggerTest() {}
+
+  virtual void SetUp() OVERRIDE {
+    util::ClearLog();
+  }
+
+ protected:
+  DISALLOW_COPY_AND_ASSIGN(LoggerTest);
+};
+
+TEST_F(LoggerTest, TestLogSeverityLevels) {
+  // Check that all messages are logged when log LogSeverity is set to INFO.
+  logging::SetMinLogLevel(logging::LOG_INFO);
+  LogSampleEvents();
+
+  const std::vector<EventLogger::Event> log = util::GetLogHistory();
+  ASSERT_EQ(3u, log.size());
+  ASSERT_EQ("[Info] Info test message", log[0].what);
+  ASSERT_EQ("[Warning] Warning info message", log[1].what);
+  ASSERT_EQ("[Error] Error info message", log[2].what);

[nhiroki, 2013/05/22 09:18:24]

How about adding ClearLog() test?

util::ClearLog();
ASSERT_EQ(0u, log.size());

[calvinlo, 2013/05/23 10:00:15]

Done.

+}
+
+TEST_F(LoggerTest, TestMinLogSeverityLevels) {
+  // Check that all messages are logged when log LogSeverity is set to INFO.

[nhiroki, 2013/05/22 09:18:24]

Can you update this comment?

[calvinlo, 2013/05/23 10:00:15]

Done. Sorry, lazy copy and paste.

+  logging::SetMinLogLevel(logging::LOG_ERROR);
+  LogSampleEvents();
+
+  const std::vector<EventLogger::Event> log = util::GetLogHistory();
+  ASSERT_EQ(1u, log.size());
+  ASSERT_EQ("[Error] Error info message", log[0].what);
+}
+
+}  // namespace sync_file_system