Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1565673002: Expose Offscreencanvas to worker (Closed)

Created:
4 years, 11 months ago by xidachen
Modified:
4 years, 11 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose Offscreencanvas to worker This CL makes it possible to construct an OffscreenCanvas on a worker, it also includes a layout test to verify that. BUG=563863 Committed: https://crrev.com/23ad5de943ee5b081a4a1f3898b8a7a1b0a286b6 Cr-Commit-Position: refs/heads/master@{#368369}

Patch Set 1 #

Total comments: 1

Patch Set 2 : should work code #

Patch Set 3 : update layout test result #

Patch Set 4 : no separate js for worker #

Messages

Total messages: 12 (3 generated)
xidachen
Hi Justin, Could you take a look? Something is wrong with the layout test, the ...
4 years, 11 months ago (2016-01-06 02:35:59 UTC) #2
Justin Novosad
https://codereview.chromium.org/1565673002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/resources/OffScreenCanvas-constructor-in-worker.js File third_party/WebKit/LayoutTests/fast/canvas/resources/OffScreenCanvas-constructor-in-worker.js (right): https://codereview.chromium.org/1565673002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/resources/OffScreenCanvas-constructor-in-worker.js#newcode1 third_party/WebKit/LayoutTests/fast/canvas/resources/OffScreenCanvas-constructor-in-worker.js:1: importScripts('../../../resources/js-test.js'); Factoring-out the js into a separate file is ...
4 years, 11 months ago (2016-01-06 15:29:40 UTC) #3
xidachen
PS#3 should work. PTAL.
4 years, 11 months ago (2016-01-06 19:44:52 UTC) #4
Justin Novosad
Ahem. js -> html
4 years, 11 months ago (2016-01-07 17:20:54 UTC) #5
xidachen
PTAL.
4 years, 11 months ago (2016-01-08 16:03:13 UTC) #6
Justin Novosad
On 2016/01/08 16:03:13, xidachen wrote: > PTAL. lgtm
4 years, 11 months ago (2016-01-08 16:30:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565673002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565673002/60001
4 years, 11 months ago (2016-01-08 16:32:46 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-08 17:53:15 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 17:54:27 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/23ad5de943ee5b081a4a1f3898b8a7a1b0a286b6
Cr-Commit-Position: refs/heads/master@{#368369}

Powered by Google App Engine
This is Rietveld 408576698