Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 156563002: Redefine is_linux to not include Android in the GN build. (Closed)

Created:
6 years, 10 months ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Redefine is_linux to not include Android in the GN build. This matches the GYP definition and seems to be what most build files expect. This also removes some additions of lib "dl" which I'm making global. R=scottmg@chromium.org TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250572

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M build/config/BUILDCONFIG.gn View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/secondary/skia/BUILD.gn View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/secondary/third_party/libxml/BUILD.gn View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M tools/gn/secondary/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
6 years, 10 months ago (2014-02-07 04:03:23 UTC) #1
scottmg
lgtm
6 years, 10 months ago (2014-02-07 17:06:53 UTC) #2
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 10 months ago (2014-02-08 02:34:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/156563002/240001
6 years, 10 months ago (2014-02-08 02:35:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-08 02:53:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=226580
6 years, 10 months ago (2014-02-08 02:53:08 UTC) #6
brettw
6 years, 10 months ago (2014-02-12 00:31:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r250572 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698