Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1565623002: Replace WebAudio MediaCodec usage with FFmpeg. A ~4x improvement. (Closed)

Created:
4 years, 11 months ago by DaleCurtis
Modified:
4 years, 11 months ago
Reviewers:
nasko, Raymond Toy
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace WebAudio MediaCodec usage with FFmpeg. A ~4x improvement. Now that ffmpeg is linked in for project spitzer (issue 507834) we can use it for audio decoding on Android; this provides a more secure (all decoding in the renderer) and faster decoding experience for WebAudio users. Using the demo page from the linked bug, the improvements are: apk size: -2162 bytes aac decode: 12.9 seconds -> 3.7 seconds (~3.5x speedup) ogg decode: 15.7 seconds -> 3.8 seconds (~4.1x speedup) BUG=424174, 570711, 570788 TEST=existing layout tests all pass. Committed: https://crrev.com/c0baf4af90ffad9436aa0c432d70365e28559219 Cr-Commit-Position: refs/heads/master@{#367881}

Patch Set 1 #

Patch Set 2 : Delete expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1302 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 4 chunks +0 lines, -37 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_renderer.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/renderer/media/android/audio_decoder_android.h View 1 chunk +0 lines, -25 lines 0 comments Download
D content/renderer/media/android/audio_decoder_android.cc View 1 chunk +0 lines, -596 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M media/base/android/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java View 1 chunk +0 lines, -293 lines 0 comments Download
M media/base/android/media_jni_registrar.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D media/base/android/webaudio_media_codec_bridge.h View 1 chunk +0 lines, -87 lines 0 comments Download
D media/base/android/webaudio_media_codec_bridge.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D media/base/android/webaudio_media_codec_info.h View 1 chunk +0 lines, -20 lines 0 comments Download
M media/media.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav View 1 Binary file 0 comments Download

Messages

Total messages: 15 (5 generated)
DaleCurtis
4 years, 11 months ago (2016-01-06 01:11:05 UTC) #2
DaleCurtis
Will likely need to update the webaudio codec expectations, rtoy@ how do you do that ...
4 years, 11 months ago (2016-01-06 01:12:53 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565623002/20001
4 years, 11 months ago (2016-01-06 01:30:03 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 03:00:49 UTC) #7
Raymond Toy
On 2016/01/06 01:12:53, DaleCurtis wrote: > Will likely need to update the webaudio codec expectations, ...
4 years, 11 months ago (2016-01-06 16:45:44 UTC) #8
Raymond Toy
lgtm Thanks so much for doing this!
4 years, 11 months ago (2016-01-06 16:49:02 UTC) #9
nasko
Awesome! I love (+0 lines, -1302 lines) type CLs :). LGTM
4 years, 11 months ago (2016-01-06 17:26:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565623002/20001
4 years, 11 months ago (2016-01-06 19:41:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-06 19:48:11 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 19:49:18 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0baf4af90ffad9436aa0c432d70365e28559219
Cr-Commit-Position: refs/heads/master@{#367881}

Powered by Google App Engine
This is Rietveld 408576698