Issue 15656002: Make ImageDecoder::setSize non-virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15656002: Make ImageDecoder::setSize non-virtual (Closed)

Created:
7 years, 7 months ago by Noel Gordon

Modified:
7 years, 7 months ago

Reviewers:
Use pkasting(at)chromium.org, eseidel

CC:
blink-reviews, eae+blinkwatch, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make ImageDecoder::setSize non-virtual No decoder overrides setSize() after blink r150783, so make the default implementation non-virtual. TEST=No change in behavior, so no new tests. BUG=None

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/platform/image-decoders/ImageDecoder.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Noel Gordon

https://codereview.chromium.org/15466003/#msg14 for reference.

7 years, 7 months ago (2013-05-22 04:48:30 UTC) #2

pdr.

Unless I'm mistaken, doesn't ICOImageDecoder.h override this?

7 years, 7 months ago (2013-05-22 04:51:00 UTC) #3

Noel Gordon

7 years, 7 months ago (2013-05-22 04:56:57 UTC) #4

Thanks pdr.  Indeed it does, and fast/images/icon-decoding.html says so. 
Closing this issue.

Expand Messages | Collapse Messages