Issue 156553007: Fix menu behavior in phone mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 156553007: Fix menu behavior in phone mode. (Closed)

Created:
6 years, 10 months ago by Arthur Evans

Modified:
6 years, 10 months ago

Reviewers:
Renato Mangini (chromium), not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix menu behavior in phone mode. This is the same basic fix we made in article.js to correct the handling of expand/collapse sections -- basically, instead of testing the media query once, test in the click event handlers, so we correctly handle devices that switch between wide & narrow modes. Renato, can you review this? We'll need Ben for the official LGTM. NOTRY=true BUG=343400 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251856