Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: sync/api/model_type_service.h

Issue 1565503003: Use MetadataChangeList and EntityChangeList in SharedModelTypeProcessor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added ClearDataTypeState Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/api/metadata_change_list.h ('k') | sync/internal_api/public/shared_model_type_processor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/api/model_type_service.h
diff --git a/sync/api/model_type_service.h b/sync/api/model_type_service.h
index f7ad9cdd76d3c75105010ec836a7ddf7a3209620..48acdbeb4f130bf98025c31ca4bf9f693f6461af 100644
--- a/sync/api/model_type_service.h
+++ b/sync/api/model_type_service.h
@@ -48,6 +48,10 @@ class SYNC_EXPORT ModelTypeService {
EntityDataList entity_data_list) = 0;
// Apply changes from the sync server locally.
+ // Please note that |entity_changes| might have fewer entries than
+ // |metadata_change_list| in case when some of the data changes are filtered
+ // out, or even be empty in case when a commit confirmation is processed and
+ // only the metadata needs to persisted.
virtual syncer::SyncError ApplySyncChanges(
scoped_ptr<MetadataChangeList> metadata_change_list,
EntityChangeList entity_changes) = 0;
« no previous file with comments | « sync/api/metadata_change_list.h ('k') | sync/internal_api/public/shared_model_type_processor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698