Fix up proguard output filtering

Fix up proguard output filtering

Removes build noise when building release on Android.

BUG=573257
Committed: https://crrev.com/a8815d201980b613bf76d8f8977c718623e74d03
Cr-Commit-Position: refs/heads/master@{#367762}

[agrieve, 2016-01-05 19:31:18]

Description was changed from

==========
Fix up proguard output filtering

Removes build noise when building release on Android.

BUG=573257
==========

to

==========
Fix up proguard output filtering

Removes build noise when building release on Android.

BUG=573257
==========

[agrieve, 2016-01-05 19:31:18]

agrieve@chromium.org changed reviewers:
+ thakis@chromium.org

[agrieve, 2016-01-05 19:31:29]

On 2016/01/05 19:31:18, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:thakis@chromium.org

❣

[Nico, 2016-01-05 19:53:08]

Thanks much! One comment about a line from the bug that seems to not be matched
below, and two optional nits

https://codereview.chromium.org/1565433002/diff/1/build/android/gyp/util/prog...
File build/android/gyp/util/proguard_util.py (right):

https://codereview.chromium.org/1565433002/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:17:
r'(Pro.*version|Note:|Reading|Preparing|.*:.*(MANIFEST\.MF|\.empty))')
nit: consider non-capturing groups (?:asdf) since you don't need the capture

https://codereview.chromium.org/1565433002/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:24: for line in output.splitlines(True):
nit: consider always naming bool parameters (splitlines(keepends=True))

https://codereview.chromium.org/1565433002/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:28: self._last_line_ignored = True
This keeps

Maybe this is program method 'android.support.v4.text.ICUCompatIcs {
java.lang.String getScript(java.lang.String); }'

lines, right?

[agrieve, 2016-01-05 20:53:25]

https://codereview.chromium.org/1565433002/diff/1/build/android/gyp/util/prog...
File build/android/gyp/util/proguard_util.py (right):

https://codereview.chromium.org/1565433002/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:17:
r'(Pro.*version|Note:|Reading|Preparing|.*:.*(MANIFEST\.MF|\.empty))')
On 2016/01/05 19:53:07, Nico wrote:
> nit: consider non-capturing groups (?:asdf) since you don't need the capture

Done.

https://codereview.chromium.org/1565433002/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:24: for line in output.splitlines(True):
On 2016/01/05 19:53:07, Nico wrote:
> nit: consider always naming bool parameters (splitlines(keepends=True))

I did actually try that, but it gives me:
>>> ''.splitlines(keepends=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: splitlines() takes no keyword arguments

https://codereview.chromium.org/1565433002/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:28: self._last_line_ignored = True
On 2016/01/05 19:53:07, Nico wrote:
> This keeps
> 
> Maybe this is program method 'android.support.v4.text.ICUCompatIcs {
> java.lang.String getScript(java.lang.String); }'
> 
> lines, right?

It hides them because in this case the line starts with a ' ' and does not match
the elif either. It's treated as a continuation of the previous line, which
looks like "Note: ..."

Tested that for a chrome_apk release build this hides all output.

[Nico, 2016-01-05 22:22:21]

lgtm

https://codereview.chromium.org/1565433002/diff/20001/build/android/gyp/util/...
File build/android/gyp/util/proguard_util.py (right):

https://codereview.chromium.org/1565433002/diff/20001/build/android/gyp/util/...
build/android/gyp/util/proguard_util.py:30: if not self._last_line_ignored:
Ooh I see, I was misreading this.

[agrieve, 2016-01-06 01:29:58]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-01-06 01:33:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1565433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1565433002/20001

[commit-bot: I haz the power, 2016-01-06 03:04:19]

Description was changed from

==========
Fix up proguard output filtering

Removes build noise when building release on Android.

BUG=573257
==========

to

==========
Fix up proguard output filtering

Removes build noise when building release on Android.

BUG=573257
==========

[commit-bot: I haz the power, 2016-01-06 03:04:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-06 03:05:15]

Description was changed from

==========
Fix up proguard output filtering

Removes build noise when building release on Android.

BUG=573257
==========

to

==========
Fix up proguard output filtering

Removes build noise when building release on Android.

BUG=573257

Committed: https://crrev.com/a8815d201980b613bf76d8f8977c718623e74d03
Cr-Commit-Position: refs/heads/master@{#367762}
==========

[commit-bot: I haz the power, 2016-01-06 03:05:15]

Patchset 2 (id:??) landed as
https://crrev.com/a8815d201980b613bf76d8f8977c718623e74d03
Cr-Commit-Position: refs/heads/master@{#367762}