Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1565433002: Fix up proguard output filtering (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix up proguard output filtering Removes build noise when building release on Android. BUG=573257 Committed: https://crrev.com/a8815d201980b613bf76d8f8977c718623e74d03 Cr-Commit-Position: refs/heads/master@{#367762}

Patch Set 1 #

Total comments: 6

Patch Set 2 : non-capturing groups #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -24 lines) Patch
M build/android/gyp/apk_obfuscate.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/gyp/proguard.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/gyp/util/proguard_util.py View 1 3 chunks +35 lines, -22 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
agrieve
On 2016/01/05 19:31:18, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:thakis@chromium.org ❣
4 years, 11 months ago (2016-01-05 19:31:29 UTC) #3
Nico
Thanks much! One comment about a line from the bug that seems to not be ...
4 years, 11 months ago (2016-01-05 19:53:08 UTC) #4
agrieve
https://codereview.chromium.org/1565433002/diff/1/build/android/gyp/util/proguard_util.py File build/android/gyp/util/proguard_util.py (right): https://codereview.chromium.org/1565433002/diff/1/build/android/gyp/util/proguard_util.py#newcode17 build/android/gyp/util/proguard_util.py:17: r'(Pro.*version|Note:|Reading|Preparing|.*:.*(MANIFEST\.MF|\.empty))') On 2016/01/05 19:53:07, Nico wrote: > nit: consider ...
4 years, 11 months ago (2016-01-05 20:53:25 UTC) #5
Nico
lgtm https://codereview.chromium.org/1565433002/diff/20001/build/android/gyp/util/proguard_util.py File build/android/gyp/util/proguard_util.py (right): https://codereview.chromium.org/1565433002/diff/20001/build/android/gyp/util/proguard_util.py#newcode30 build/android/gyp/util/proguard_util.py:30: if not self._last_line_ignored: Ooh I see, I was ...
4 years, 11 months ago (2016-01-05 22:22:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565433002/20001
4 years, 11 months ago (2016-01-06 01:33:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-06 03:04:19 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 03:05:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8815d201980b613bf76d8f8977c718623e74d03
Cr-Commit-Position: refs/heads/master@{#367762}

Powered by Google App Engine
This is Rietveld 408576698