Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1565403005: Update gpu_tests to use cloud_storage from catapult. (Closed)

Created:
4 years, 11 months ago by aiolos (Not reviewing)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update gpu_tests to use cloud_storage from catapult. This is part of the migration work needed before we can remove the version in telemetry. BUG=565604 Committed: https://crrev.com/155b209155e64ba7d265c4b23452db21a1110e77 Cr-Commit-Position: refs/heads/master@{#370442}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use chromium_src_dir base path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M content/test/gpu/gpu_tests/__init__.py View 1 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
aiolos (Not reviewing)
4 years, 11 months ago (2016-01-08 21:05:29 UTC) #3
aiolos (Not reviewing)
https://codereview.chromium.org/1565403005/diff/1/content/test/gpu/gpu_tests/__init__.py File content/test/gpu/gpu_tests/__init__.py (right): https://codereview.chromium.org/1565403005/diff/1/content/test/gpu/gpu_tests/__init__.py#newcode10 content/test/gpu/gpu_tests/__init__.py:10: os.path.dirname(__file__), '..', '..', '..', '..', 'tools', 'telemetry')) I could ...
4 years, 11 months ago (2016-01-08 21:07:17 UTC) #4
Ken Russell (switch to Gerrit)
LGTM with comment. https://codereview.chromium.org/1565403005/diff/1/content/test/gpu/gpu_tests/__init__.py File content/test/gpu/gpu_tests/__init__.py (right): https://codereview.chromium.org/1565403005/diff/1/content/test/gpu/gpu_tests/__init__.py#newcode10 content/test/gpu/gpu_tests/__init__.py:10: os.path.dirname(__file__), '..', '..', '..', '..', 'tools', ...
4 years, 11 months ago (2016-01-08 22:05:57 UTC) #5
aiolos (Not reviewing)
https://codereview.chromium.org/1565403005/diff/1/content/test/gpu/gpu_tests/__init__.py File content/test/gpu/gpu_tests/__init__.py (right): https://codereview.chromium.org/1565403005/diff/1/content/test/gpu/gpu_tests/__init__.py#newcode10 content/test/gpu/gpu_tests/__init__.py:10: os.path.dirname(__file__), '..', '..', '..', '..', 'tools', 'telemetry')) On 2016/01/08 ...
4 years, 11 months ago (2016-01-08 22:16:12 UTC) #6
Ken Russell (switch to Gerrit)
Still LGTM
4 years, 11 months ago (2016-01-08 22:16:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565403005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565403005/20001
4 years, 11 months ago (2016-01-20 18:31:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-20 19:46:12 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 19:47:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/155b209155e64ba7d265c4b23452db21a1110e77
Cr-Commit-Position: refs/heads/master@{#370442}

Powered by Google App Engine
This is Rietveld 408576698