Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Issue 1565403003: Print the data we get back from the tcp socket meta data service (Closed)

Created:
4 years, 11 months ago by ricow1
Modified:
4 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print the data we get back from the tcp socket meta data service We are seeing flakes on win64 with this test R=sgjesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/55c7aa561b208caea849de2812f1ed761cebc0ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M runtime/observatory/tests/service/tcp_socket_service_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Søren Gjesse
lgtm
4 years, 11 months ago (2016-01-08 10:30:34 UTC) #1
ricow1
4 years, 11 months ago (2016-01-08 10:46:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
55c7aa561b208caea849de2812f1ed761cebc0ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698