Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2552)

Unified Diff: dart/tests/standalone/io/http_server_early_client_close_test.dart

Issue 15654009: Version 0.5.11.1 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tools/VERSION » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/standalone/io/http_server_early_client_close_test.dart
===================================================================
--- dart/tests/standalone/io/http_server_early_client_close_test.dart (revision 23199)
+++ dart/tests/standalone/io/http_server_early_client_close_test.dart (working copy)
@@ -18,10 +18,10 @@
Expect.fail("No data response was expected");
});
socket.add(data);
- socket.done.then((_) {
- socket.destroy();
- });
- return socket.close();
+ return socket.close()
+ .then((_) {
+ socket.destroy();
+ });
});
}
@@ -38,6 +38,7 @@
bool calledOnError = false;
bool calledOnDone = false;
ReceivePort port = new ReceivePort();
+ var requestCompleter = new Completer();
server.listen(
(request) {
Expect.isTrue(expectRequest);
@@ -46,13 +47,15 @@
calledOnRequest = true;
request.listen(
(_) {},
+ onDone: () {
+ requestCompleter.complete();
+ },
onError: (error) {
Expect.isFalse(calledOnError);
Expect.equals(exception, error.message);
calledOnError = true;
if (exception != null) port.close();
});
- server.close();
},
onDone: () {
Expect.equals(expectRequest, calledOnRequest);
@@ -67,7 +70,8 @@
if (d == null) Expect.fail("Invalid data");
sendData(d, server.port)
.then((_) {
- if (!expectRequest) server.close();
+ if (!expectRequest) requestCompleter.complete();
+ requestCompleter.future.then((_) => server.close());
});
return c.future;
« no previous file with comments | « no previous file | dart/tools/VERSION » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698