Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1565343002: MediaRecorder: content browsertests fix a few lint warnings in mediarecorder_test.html (Closed)

Created:
4 years, 11 months ago by cpaulin (no longer in chrome)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaRecorder: content browsertests fix a few lint warnings in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. Committed: https://crrev.com/7831a89af115138ba54b3e9b64f5aa040a566853 Cr-Commit-Position: refs/heads/master@{#368643}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unused videoSize in testPausePreventsDataavailableFromBeingFired #

Patch Set 3 : Removed the "== true" checks in 4 locations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M content/test/data/media/mediarecorder_test.html View 1 2 10 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
cpaulin (no longer in chrome)
This CL fixes the lint warnings in mediarecorder_test.html, no new functionality added. Please review at ...
4 years, 11 months ago (2016-01-07 22:30:42 UTC) #2
mcasas
https://codereview.chromium.org/1565343002/diff/1/content/test/data/media/mediarecorder_test.html File content/test/data/media/mediarecorder_test.html (right): https://codereview.chromium.org/1565343002/diff/1/content/test/data/media/mediarecorder_test.html#newcode360 content/test/data/media/mediarecorder_test.html:360: var videoSize = 0; Unused as well, as I ...
4 years, 11 months ago (2016-01-07 23:04:11 UTC) #4
cpaulin (no longer in chrome)
Small review to fix lint warnings in mediarecorder_test.html
4 years, 11 months ago (2016-01-07 23:09:12 UTC) #6
cpaulin (no longer in chrome)
Removed unused videoSize from testPausePreventsDataavailableFromBeingFired. Ready for review https://codereview.chromium.org/1565343002/diff/1/content/test/data/media/mediarecorder_test.html File content/test/data/media/mediarecorder_test.html (right): https://codereview.chromium.org/1565343002/diff/1/content/test/data/media/mediarecorder_test.html#newcode360 content/test/data/media/mediarecorder_test.html:360: var ...
4 years, 11 months ago (2016-01-07 23:14:06 UTC) #7
phoglund_chromium
lgtm
4 years, 11 months ago (2016-01-08 09:46:13 UTC) #8
mcasas
4 years, 11 months ago (2016-01-08 18:03:02 UTC) #9
cpaulin (no longer in chrome)
mcasas@ PTAL
4 years, 11 months ago (2016-01-08 19:57:08 UTC) #10
cpaulin (no longer in chrome)
New Patch set is out: removed the "== true" boolean expressions in 4 locations
4 years, 11 months ago (2016-01-08 20:49:51 UTC) #11
mcasas
lgtm
4 years, 11 months ago (2016-01-08 23:19:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565343002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565343002/30001
4 years, 11 months ago (2016-01-11 18:39:18 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 11 months ago (2016-01-11 19:49:46 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 19:50:42 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7831a89af115138ba54b3e9b64f5aa040a566853
Cr-Commit-Position: refs/heads/master@{#368643}

Powered by Google App Engine
This is Rietveld 408576698