|
|
Chromium Code Reviews|
Created:
4 years, 11 months ago by cpaulin (no longer in chrome) Modified:
4 years, 11 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMediaRecorder: content browsertests fix a few lint warnings in mediarecorder_test.html
This CL fixes a few lint warnings scattered around
mediarecorder_test.html. No new functionality added.
BUG=575323
Test=On linux host and trybots.
Committed: https://crrev.com/7831a89af115138ba54b3e9b64f5aa040a566853
Cr-Commit-Position: refs/heads/master@{#368643}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Removed unused videoSize in testPausePreventsDataavailableFromBeingFired #Patch Set 3 : Removed the "== true" checks in 4 locations #Messages
Total messages: 21 (9 generated)
cpaulin@chromium.org changed reviewers: + mcasas@chromium.org
This CL fixes the lint warnings in mediarecorder_test.html, no new functionality added. Please review at your leisure.
Description was changed from ========== MediaRecorder: fix a few lint errors in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. ========== to ========== MediaRecorder: fix a few lint warnings in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. ==========
https://codereview.chromium.org/1565343002/diff/1/content/test/data/media/med... File content/test/data/media/mediarecorder_test.html (right): https://codereview.chromium.org/1565343002/diff/1/content/test/data/media/med... content/test/data/media/mediarecorder_test.html:360: var videoSize = 0; Unused as well, as I wrote in the bug.
cpaulin@chromium.org changed reviewers: + phoglund@chromium.org
Small review to fix lint warnings in mediarecorder_test.html
Removed unused videoSize from testPausePreventsDataavailableFromBeingFired. Ready for review https://codereview.chromium.org/1565343002/diff/1/content/test/data/media/med... File content/test/data/media/mediarecorder_test.html (right): https://codereview.chromium.org/1565343002/diff/1/content/test/data/media/med... content/test/data/media/mediarecorder_test.html:360: var videoSize = 0; On 2016/01/07 23:04:11, mcasas wrote: > Unused as well, as I wrote in the bug. That one got away.
lgtm
mcasas@ PTAL
New Patch set is out: removed the "== true" boolean expressions in 4 locations
lgtm
Description was changed from ========== MediaRecorder: fix a few lint warnings in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. ========== to ========== MediaRecorder: content browsertests fix a few lint warning in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. ==========
Description was changed from ========== MediaRecorder: content browsertests fix a few lint warning in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. ========== to ========== MediaRecorder: content browsertests fix a few lint warnings in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. ==========
The CQ bit was checked by cpaulin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from phoglund@chromium.org Link to the patchset: https://codereview.chromium.org/1565343002/#ps30001 (title: "Removed the "== true" checks in 4 locations")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565343002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565343002/30001
Message was sent while issue was closed.
Description was changed from ========== MediaRecorder: content browsertests fix a few lint warnings in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. ========== to ========== MediaRecorder: content browsertests fix a few lint warnings in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. ==========
Message was sent while issue was closed.
Committed patchset #3 (id:30001)
Message was sent while issue was closed.
Description was changed from ========== MediaRecorder: content browsertests fix a few lint warnings in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. ========== to ========== MediaRecorder: content browsertests fix a few lint warnings in mediarecorder_test.html This CL fixes a few lint warnings scattered around mediarecorder_test.html. No new functionality added. BUG=575323 Test=On linux host and trybots. Committed: https://crrev.com/7831a89af115138ba54b3e9b64f5aa040a566853 Cr-Commit-Position: refs/heads/master@{#368643} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7831a89af115138ba54b3e9b64f5aa040a566853 Cr-Commit-Position: refs/heads/master@{#368643} |
