Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1565313003: Revert of Add guards to GrTextureProvider (Closed)

Created:
4 years, 11 months ago by joshualitt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@gpudeviceguards
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add guards to GrTextureProvider (patchset #5 id:80001 of https://codereview.chromium.org/1567983002/ ) Reason for revert: breaking asan bot Original issue's description: > Add guards to GrTextureProvider > > TBR=bsalomon@google.com > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1567983002 > > Committed: https://skia.googlesource.com/skia/+/b30dd1db1d914b85a691b4724713ba1b0f16cd6c TBR=robertphillips@google.com,joshualitt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9a9515e081c54efdd5a0b0f662c013cbeef6d63f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -51 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrTextureProvider.h View 4 chunks +10 lines, -7 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/GrResourceProvider.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrTextureProvider.cpp View 7 chunks +1 line, -34 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
joshualitt
Created Revert of Add guards to GrTextureProvider
4 years, 11 months ago (2016-01-07 21:17:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565313003/1
4 years, 11 months ago (2016-01-07 21:17:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9a9515e081c54efdd5a0b0f662c013cbeef6d63f
4 years, 11 months ago (2016-01-07 21:17:41 UTC) #4
joshualitt
4 years, 11 months ago (2016-01-11 16:04:37 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1575093002/ by joshualitt@google.com.

The reason for reverting is: should be fixed.

Powered by Google App Engine
This is Rietveld 408576698