[promise] make builtin resolve functions and executors non-constructors

src/js/promise.js

Index: src/js/promise.js
diff --git a/src/js/promise.js b/src/js/promise.js
index b9100513ae1c6155abc0158acde2d602f7583a3e..306964a9da3e1383061f3a0b5e03b1d0395d1d5f 100644
--- a/src/js/promise.js
+++ b/src/js/promise.js
@@ -37,17 +37,17 @@ var lastMicrotaskId = 0;
 function CreateResolvingFunctions(promise) {
   var alreadyResolved = false;
 
-  var resolve = function(value) {
+  var resolve = (0, value => {

[adamk, 2016/01/07 22:22:28]

I'd prefer to leave the "(0," out for now, and leave it as a blocker against the
ES6 function name thing to make sure to scrub our natives for cases where we're
leaking names this way. It's unrelated to the tests you're fixing anyway.

     if (alreadyResolved === true) return;
     alreadyResolved = true;
     PromiseResolve(promise, value);
-  };
+  });
 
-  var reject = function(reason) {
+  var reject = (0, reason => {
     if (alreadyResolved === true) return;
     alreadyResolved = true;
     PromiseReject(promise, reason);
-  };
+  });
 
   return {
     __proto__: null,
@@ -230,7 +230,7 @@ function NewPromiseCapability(C) {
   }
 
   var result = {promise: UNDEFINED, resolve: UNDEFINED, reject: UNDEFINED };
-  result.promise = new C(function(resolve, reject) {
+  result.promise = new C((resolve, reject) => {
     if (!IS_UNDEFINED(result.resolve) || !IS_UNDEFINED(result.reject))
         throw MakeTypeError(kPromiseExecutorAlreadyInvoked);
     result.resolve = resolve;
@@ -348,7 +348,7 @@ function PromiseAll(iterable) {
 
   function CreateResolveElementFunction(index, values, promiseCapability) {
     var alreadyCalled = false;
-    return function(x) {
+    return (x) => {
       if (alreadyCalled === true) return;
       alreadyCalled = true;
       values[index] = x;
@@ -394,8 +394,8 @@ function PromiseRace(iterable) {
   var deferred = NewPromiseCapability(this);
   try {
     for (var value of iterable) {
-      var reject = function(r) { deferred.reject(r) };
-      this.resolve(value).then(function(x) { deferred.resolve(x) }, reject);
+      var reject = (0, reason => { deferred.reject(reason); });
+      this.resolve(value).then((x) => { deferred.resolve(x) }, reject);
       SET_PRIVATE(reject, promiseCombinedDeferredSymbol, deferred);
     }
   } catch (e) {