[promise] make builtin resolve functions and executors non-constructors

[promise] make builtin resolve functions and executors non-constructors

Fixes a number of test262 tests, including:

- built-ins/Promise/reject-function-nonconstructor.js
- built-ins/Promise/resolve-function-nonconstructor.js
- built-ins/Promise/all/resolve-element-function-nonconstructor.js
- built-ins/Promise/executor-function-nonconstructor.js

BUG=v8:4633
LOG=N
R=adamk@chromium.org, cbruni@chromium.org, littledan@chromium.org

Committed: https://crrev.com/96c6b338639ee87e4344fa14472b430d5b5f2666
Cr-Commit-Position: refs/heads/master@{#33164}

[caitp (gmail), 2016-01-07 21:46:24]

Another opportunity for passing more test262.

The `(0, arrowFunction)` pattern used in this CL is just there to prevent ES6
function name inferrence from impacting these functions. However, this doesn't
matter for now, so it could be removed.

[adamk, 2016-01-07 22:22:28]

https://codereview.chromium.org/1565303004/diff/1/src/js/promise.js
File src/js/promise.js (right):

https://codereview.chromium.org/1565303004/diff/1/src/js/promise.js#newcode40
src/js/promise.js:40: var resolve = (0, value => {
I'd prefer to leave the "(0," out for now, and leave it as a blocker against the
ES6 function name thing to make sure to scrub our natives for cases where we're
leaking names this way. It's unrelated to the tests you're fixing anyway.

[caitp (gmail), 2016-01-07 23:33:40]

On 2016/01/07 22:22:28, adamk wrote:
> https://codereview.chromium.org/1565303004/diff/1/src/js/promise.js
> File src/js/promise.js (right):
> 
> https://codereview.chromium.org/1565303004/diff/1/src/js/promise.js#newcode40
> src/js/promise.js:40: var resolve = (0, value => {
> I'd prefer to leave the "(0," out for now, and leave it as a blocker against
the
> ES6 function name thing to make sure to scrub our natives for cases where
we're
> leaking names this way. It's unrelated to the tests you're fixing anyway.

Alright, done

[adamk, 2016-01-07 23:38:45]

lgtm

[caitp (gmail), 2016-01-07 23:39:55]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2016-01-07 23:40:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1565303004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1565303004/20001

[commit-bot: I haz the power, 2016-01-08 00:19:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-08 00:20:17]

Description was changed from

==========
[promise] make builtin resolve functions and executors non-constructors

Fixes a number of test262 tests, including:

- built-ins/Promise/reject-function-nonconstructor.js
- built-ins/Promise/resolve-function-nonconstructor.js
- built-ins/Promise/all/resolve-element-function-nonconstructor.js
- built-ins/Promise/executor-function-nonconstructor.js

BUG=v8:4633
LOG=N
R=adamk@chromium.org, cbruni@chromium.org, littledan@chromium.org
==========

to

==========
[promise] make builtin resolve functions and executors non-constructors

Fixes a number of test262 tests, including:

- built-ins/Promise/reject-function-nonconstructor.js
- built-ins/Promise/resolve-function-nonconstructor.js
- built-ins/Promise/all/resolve-element-function-nonconstructor.js
- built-ins/Promise/executor-function-nonconstructor.js

BUG=v8:4633
LOG=N
R=adamk@chromium.org, cbruni@chromium.org, littledan@chromium.org

Committed: https://crrev.com/96c6b338639ee87e4344fa14472b430d5b5f2666
Cr-Commit-Position: refs/heads/master@{#33164}
==========

[commit-bot: I haz the power, 2016-01-08 00:20:18]

Patchset 2 (id:??) landed as
https://crrev.com/96c6b338639ee87e4344fa14472b430d5b5f2666
Cr-Commit-Position: refs/heads/master@{#33164}