Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/gpu/GrDrawContext.cpp

Issue 1565303003: Revert of Make a single GrSingleOwner in GrContext (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/GrContext.cpp ('k') | src/gpu/GrDrawingManager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright 2015 Google Inc. 3 * Copyright 2015 Google Inc.
4 * 4 *
5 * Use of this source code is governed by a BSD-style license that can be 5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file. 6 * found in the LICENSE file.
7 */ 7 */
8 8
9 #include "GrBatchTest.h" 9 #include "GrBatchTest.h"
10 #include "GrColor.h" 10 #include "GrColor.h"
(...skipping 10 matching lines...) Expand all
21 #include "batches/GrDrawAtlasBatch.h" 21 #include "batches/GrDrawAtlasBatch.h"
22 #include "batches/GrDrawVerticesBatch.h" 22 #include "batches/GrDrawVerticesBatch.h"
23 #include "batches/GrRectBatchFactory.h" 23 #include "batches/GrRectBatchFactory.h"
24 #include "batches/GrNinePatch.h" // TODO Factory 24 #include "batches/GrNinePatch.h" // TODO Factory
25 25
26 #include "text/GrAtlasTextContext.h" 26 #include "text/GrAtlasTextContext.h"
27 #include "text/GrStencilAndCoverTextContext.h" 27 #include "text/GrStencilAndCoverTextContext.h"
28 28
29 #define ASSERT_OWNED_RESOURCE(R) SkASSERT(!(R) || (R)->getContext() == fDrawingM anager->getContext()) 29 #define ASSERT_OWNED_RESOURCE(R) SkASSERT(!(R) || (R)->getContext() == fDrawingM anager->getContext())
30 #define ASSERT_SINGLE_OWNER \ 30 #define ASSERT_SINGLE_OWNER \
31 SkDEBUGCODE(GrSingleOwner::AutoEnforce debug_SingleOwner(fSingleOwner);) 31 SkDEBUGCODE(GrSingleOwner::AutoEnforce debug_SingleOwner(&fSingleOwner);)
32 #define RETURN_IF_ABANDONED if (fDrawingManager->abandoned()) { return; } 32 #define RETURN_IF_ABANDONED if (fDrawingManager->abandoned()) { return; }
33 #define RETURN_FALSE_IF_ABANDONED if (fDrawingManager->abandoned()) { return fa lse; } 33 #define RETURN_FALSE_IF_ABANDONED if (fDrawingManager->abandoned()) { return fa lse; }
34 #define RETURN_NULL_IF_ABANDONED if (fDrawingManager->abandoned()) { return nu llptr; } 34 #define RETURN_NULL_IF_ABANDONED if (fDrawingManager->abandoned()) { return nu llptr; }
35 35
36 class AutoCheckFlush { 36 class AutoCheckFlush {
37 public: 37 public:
38 AutoCheckFlush(GrDrawingManager* drawingManager) : fDrawingManager(drawingMa nager) { 38 AutoCheckFlush(GrDrawingManager* drawingManager) : fDrawingManager(drawingMa nager) {
39 SkASSERT(fDrawingManager); 39 SkASSERT(fDrawingManager);
40 } 40 }
41 ~AutoCheckFlush() { fDrawingManager->getContext()->flushIfNecessary(); } 41 ~AutoCheckFlush() { fDrawingManager->getContext()->flushIfNecessary(); }
42 42
43 private: 43 private:
44 GrDrawingManager* fDrawingManager; 44 GrDrawingManager* fDrawingManager;
45 }; 45 };
46 46
47 // In MDB mode the reffing of the 'getLastDrawTarget' call's result allows in-pr ogress 47 // In MDB mode the reffing of the 'getLastDrawTarget' call's result allows in-pr ogress
48 // drawTargets to be picked up and added to by drawContexts lower in the call 48 // drawTargets to be picked up and added to by drawContexts lower in the call
49 // stack. When this occurs with a closed drawTarget, a new one will be allocated 49 // stack. When this occurs with a closed drawTarget, a new one will be allocated
50 // when the drawContext attempts to use it (via getDrawTarget). 50 // when the drawContext attempts to use it (via getDrawTarget).
51 GrDrawContext::GrDrawContext(GrDrawingManager* drawingMgr, 51 GrDrawContext::GrDrawContext(GrDrawingManager* drawingMgr,
52 GrRenderTarget* rt, 52 GrRenderTarget* rt,
53 const SkSurfaceProps* surfaceProps, 53 const SkSurfaceProps* surfaceProps)
54 GrSingleOwner* singleOwner)
55 : fDrawingManager(drawingMgr) 54 : fDrawingManager(drawingMgr)
56 , fRenderTarget(rt) 55 , fRenderTarget(rt)
57 , fDrawTarget(SkSafeRef(rt->getLastDrawTarget())) 56 , fDrawTarget(SkSafeRef(rt->getLastDrawTarget()))
58 , fTextContext(nullptr) 57 , fTextContext(nullptr)
59 , fSurfaceProps(SkSurfacePropsCopyOrDefault(surfaceProps)) 58 , fSurfaceProps(SkSurfacePropsCopyOrDefault(surfaceProps)) {
60 , fSingleOwner(singleOwner) {
61 SkDEBUGCODE(this->validate();) 59 SkDEBUGCODE(this->validate();)
62 } 60 }
63 61
64 #ifdef SK_DEBUG 62 #ifdef SK_DEBUG
65 void GrDrawContext::validate() const { 63 void GrDrawContext::validate() const {
66 SkASSERT(fRenderTarget); 64 SkASSERT(fRenderTarget);
67 ASSERT_OWNED_RESOURCE(fRenderTarget); 65 ASSERT_OWNED_RESOURCE(fRenderTarget);
68 66
69 if (fDrawTarget && !fDrawTarget->isClosed()) { 67 if (fDrawTarget && !fDrawTarget->isClosed()) {
70 SkASSERT(fRenderTarget->getLastDrawTarget() == fDrawTarget); 68 SkASSERT(fRenderTarget->getLastDrawTarget() == fDrawTarget);
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
825 pr->drawPath(args); 823 pr->drawPath(args);
826 } 824 }
827 825
828 void GrDrawContext::drawBatch(GrPipelineBuilder* pipelineBuilder, GrDrawBatch* b atch) { 826 void GrDrawContext::drawBatch(GrPipelineBuilder* pipelineBuilder, GrDrawBatch* b atch) {
829 ASSERT_SINGLE_OWNER 827 ASSERT_SINGLE_OWNER
830 RETURN_IF_ABANDONED 828 RETURN_IF_ABANDONED
831 SkDEBUGCODE(this->validate();) 829 SkDEBUGCODE(this->validate();)
832 830
833 this->getDrawTarget()->drawBatch(*pipelineBuilder, batch); 831 this->getDrawTarget()->drawBatch(*pipelineBuilder, batch);
834 } 832 }
OLDNEW
« no previous file with comments | « src/gpu/GrContext.cpp ('k') | src/gpu/GrDrawingManager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698