chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.cc - Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/service_discovery_client_mac.mm ('k') | chrome/browser/printing/cloud_print/privet_traffic_detector.cc » ('j') | content/browser/renderer_host/pepper/pepper_socket_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.cc

diff --git a/chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.cc b/chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.cc

index c18a11bc49bbafc7917903f6a9ddf4edf95111af..45320e3a730e170d94bc5df7a76cc8904bebde29 100644

--- a/chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.cc

+++ b/chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.cc

@@ -57,7 +57,7 @@ void PrivetHTTPAsynchronousFactoryImpl::ResolutionImpl::Start(

void PrivetHTTPAsynchronousFactoryImpl::ResolutionImpl::ResolveComplete(

const ResultCallback& callback,

const net::IPEndPoint& endpoint) {

- if (endpoint.address().empty())

+ if (endpoint.address_number().empty())

return callback.Run(scoped_ptr<PrivetHTTPClient>());

net::HostPortPair new_address = net::HostPortPair::FromIPEndPoint(endpoint);