chrome/browser/extensions/api/gcd_private/gcd_private_api.cc - Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/gcd_private/gcd_private_api.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/local_discovery/service_discovery_client_mac.mm » ('j') | content/browser/renderer_host/pepper/pepper_socket_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/gcd_private/gcd_private_api.cc

diff --git a/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc b/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc

index c0844f6f9c2239c92d82616abe26d5f600c333cc..79e27fa4e9d0adef4c7c7b4f30c2fe6c3148355f 100644

--- a/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc

+++ b/chrome/browser/extensions/api/gcd_private/gcd_private_api.cc

@@ -136,7 +136,7 @@ void GcdPrivateAPIImpl::CreateSession(const std::string& service_name,

void GcdPrivateAPIImpl::OnServiceResolved(int session_id,

const CreateSessionCallback& callback,

const net::IPEndPoint& endpoint) {

- if (endpoint.address().empty()) {

+ if (endpoint.address_number().empty()) {

return callback.Run(session_id, gcd_private::STATUS_SERVICERESOLUTIONERROR,

base::DictionaryValue());

}