net/socket/tcp_client_socket_unittest.cc - Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_client_socket_unittest.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase for ChromeOS Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/tcp_client_socket_unittest.cc

diff --git a/net/socket/tcp_client_socket_unittest.cc b/net/socket/tcp_client_socket_unittest.cc

index ce0c53559f862a50d0f5562c0759defa309a878f..5e0d948c32d40e6100da8baac40b8cdf3781fb37 100644

--- a/net/socket/tcp_client_socket_unittest.cc

+++ b/net/socket/tcp_client_socket_unittest.cc

@@ -36,7 +36,7 @@ TEST(TCPClientSocketTest, BindLoopbackToLoopback) {

IPEndPoint local_address_result;

EXPECT_EQ(OK, socket.GetLocalAddress(&local_address_result));

- EXPECT_EQ(lo_address, local_address_result.address());

+ EXPECT_EQ(lo_address, local_address_result.address().bytes());

TestCompletionCallback connect_callback;

EXPECT_EQ(ERR_IO_PENDING, socket.Connect(connect_callback.callback()));

« no previous file with comments | « net/socket/socks_client_socket.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »