Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Unified Diff: net/quic/crypto/crypto_server_test.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback eroman Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/crypto_server_test.cc
diff --git a/net/quic/crypto/crypto_server_test.cc b/net/quic/crypto/crypto_server_test.cc
index b2fa3472e189961772a5c54787f79161a45af1c3..26038655fed68779c8b87d50f5ff1abdf24a4ae3 100644
--- a/net/quic/crypto/crypto_server_test.cc
+++ b/net/quic/crypto/crypto_server_test.cc
@@ -253,15 +253,15 @@ class CryptoServerTest : public ::testing::TestWithParam<TestParams> {
ASSERT_TRUE(server_hello.GetStringPiece(kCADR, &address));
QuicSocketAddressCoder decoder;
ASSERT_TRUE(decoder.Decode(address.data(), address.size()));
- EXPECT_EQ(client_address_.address(), decoder.ip());
+ EXPECT_EQ(client_address_.address().bytes(), decoder.ip());
EXPECT_EQ(client_address_.port(), decoder.port());
}
void ShouldSucceed(const CryptoHandshakeMessage& message) {
bool called = false;
IPAddressNumber server_ip;
- config_.ValidateClientHello(message, client_address_.address(), server_ip,
- supported_versions_.front(), &clock_,
+ config_.ValidateClientHello(message, client_address_.address().bytes(),
+ server_ip, supported_versions_.front(), &clock_,
&crypto_proof_,
new ValidateCallback(this, true, "", &called));
EXPECT_TRUE(called);
@@ -279,7 +279,7 @@ class CryptoServerTest : public ::testing::TestWithParam<TestParams> {
bool* called) {
IPAddressNumber server_ip;
config_.ValidateClientHello(
- message, client_address_.address(), server_ip,
+ message, client_address_.address().bytes(), server_ip,
supported_versions_.front(), &clock_, &crypto_proof_,
new ValidateCallback(this, false, error_substr, called));
}
@@ -1167,7 +1167,7 @@ TEST_P(AsyncStrikeServerVerificationTest, AsyncReplayProtection) {
bool called = false;
IPAddressNumber server_ip;
- config_.ValidateClientHello(msg, client_address_.address(), server_ip,
+ config_.ValidateClientHello(msg, client_address_.address().bytes(), server_ip,
client_version_, &clock_, &crypto_proof_,
new ValidateCallback(this, true, "", &called));
// The verification request was queued.
@@ -1183,7 +1183,7 @@ TEST_P(AsyncStrikeServerVerificationTest, AsyncReplayProtection) {
EXPECT_EQ(kSHLO, out_.tag());
// Rejected if replayed.
- config_.ValidateClientHello(msg, client_address_.address(), server_ip,
+ config_.ValidateClientHello(msg, client_address_.address().bytes(), server_ip,
client_version_, &clock_, &crypto_proof_,
new ValidateCallback(this, true, "", &called));
// The verification request was queued.

Powered by Google App Engine
This is Rietveld 408576698