net/http/http_network_transaction.cc - Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction.cc

Issue 1565303002: Change IPEndpoint::address() to return a net::IPAddress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback eroman Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/dns/dns_config_service_posix.cc ('K') | « net/ftp/ftp_network_transaction.cc ('k') | net/http/http_network_transaction_unittest.cc » ('j') | net/http/http_network_transaction_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_network_transaction.cc

diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc

index 201e3915a24f7c637cd382906ce8d7fdbb0fa1d0..8ef98a6183bf0fccb1eb4e3f8cd465b36b35facf 100644

--- a/net/http/http_network_transaction.cc

+++ b/net/http/http_network_transaction.cc

@@ -460,7 +460,7 @@ bool HttpNetworkTransaction::GetLoadTimingInfo(

}

bool HttpNetworkTransaction::GetRemoteEndpoint(IPEndPoint* endpoint) const {

- if (!remote_endpoint_.address().size())

+ if (!remote_endpoint_.address().bytes().size())

eroman 2016/01/13 23:19:42 no change needed here per earlier comment (address

martijnc 2016/01/14 22:48:17 Done.

return false;

*endpoint = remote_endpoint_;