chrome/browser/media_galleries/fileapi/media_path_filter.cc - Issue 15653004: Picasa import: Make NativeMediaFileUtil an AsyncFileUtil

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/media_path_filter.cc

Issue 15653004: Picasa import: Make NativeMediaFileUtil an AsyncFileUtil (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/media_path_filter.h ('k') | chrome/browser/media_galleries/fileapi/native_media_file_util.h » ('j') | chrome/browser/media_galleries/fileapi/native_media_file_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/media_path_filter.cc

diff --git a/chrome/browser/media_galleries/fileapi/media_path_filter.cc b/chrome/browser/media_galleries/fileapi/media_path_filter.cc

index b383db2459dbfc63f9367ca7f49ba2fea0e96198..fb6a4e4598d582f4b6387a0dafa7bdc7d84d17ee 100644

--- a/chrome/browser/media_galleries/fileapi/media_path_filter.cc

+++ b/chrome/browser/media_galleries/fileapi/media_path_filter.cc

@@ -76,11 +76,11 @@ MediaPathFilter::MediaPathFilter()

MediaPathFilter::~MediaPathFilter() {

}

-bool MediaPathFilter::Match(const base::FilePath& path) {

+bool MediaPathFilter::Match(const base::FilePath::StringType& base_name) {

vandebo (ex-Chrome) 2013/05/30 18:39:19 Since this method really wants a FilePath, it shou

tommycli 2013/05/30 19:35:20 Done.

EnsureInitialized();

return std::binary_search(media_file_extensions_.begin(),

media_file_extensions_.end(),

- StringToLowerASCII(path.Extension()));

vandebo (ex-Chrome) 2013/05/30 18:39:19 I think we want to ensure that the extension is lo

tommycli 2013/05/30 19:35:20 Done.

+ base::FilePath(base_name).Extension());

}

void MediaPathFilter::EnsureInitialized() {