Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5869)

Unified Diff: chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc

Issue 15653004: Picasa import: Make NativeMediaFileUtil an AsyncFileUtil (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restore a test Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc
diff --git a/chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc b/chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc
index bfa565f5bdd9674b9fd4b3e5a3915101f04d9c32..1f0fd10c3ef31a86248391a8611960d8841231c4 100644
--- a/chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc
+++ b/chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc
@@ -11,6 +11,7 @@
#include "base/message_loop.h"
#include "base/stringprintf.h"
#include "base/time.h"
+#include "chrome/browser/media_galleries/fileapi/async_file_util_test_helper.h"
#include "chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.h"
#include "chrome/browser/media_galleries/fileapi/media_path_filter.h"
#include "chrome/browser/media_galleries/fileapi/picasa/picasa_album_table_reader.h"
@@ -146,10 +147,9 @@ class TestMediaFileSystemMountPointProvider
public:
TestMediaFileSystemMountPointProvider(
const base::FilePath& profile_path,
- scoped_ptr<PicasaFileUtil> picasa_file_util)
+ PicasaFileUtil* picasa_file_util)
: chrome::MediaFileSystemMountPointProvider(profile_path),
- test_file_util_(new fileapi::AsyncFileUtilAdapter(
- picasa_file_util.release())) {
+ test_file_util_(picasa_file_util) {
}
virtual fileapi::AsyncFileUtil*
@@ -186,8 +186,6 @@ class PicasaFileUtilTest : public testing::Test {
scoped_ptr<PicasaDataProvider> data_provider(
new PicasaDataProvider(test_helper_->GetTempDirPath()));
- scoped_ptr<PicasaFileUtil> file_util(new TestPicasaFileUtil(
- data_provider.Pass()));
ASSERT_TRUE(profile_dir_.CreateUniqueTempDir());
@@ -195,9 +193,9 @@ class PicasaFileUtilTest : public testing::Test {
new quota::MockSpecialStoragePolicy();
ScopedVector<fileapi::FileSystemMountPointProvider> additional_providers;
- additional_providers.push_back(
- new TestMediaFileSystemMountPointProvider(profile_dir_.path(),
- file_util.Pass()));
+ additional_providers.push_back(new TestMediaFileSystemMountPointProvider(
+ profile_dir_.path(),
+ new TestPicasaFileUtil(data_provider.Pass())));
file_system_context_ = new fileapi::FileSystemContext(
fileapi::FileSystemTaskRunners::CreateMockTaskRunners(),
@@ -387,19 +385,24 @@ TEST_F(PicasaFileUtilTest, NameDeduplication) {
scoped_ptr<PicasaDataProvider> data_provider(
new TestPicasaDataProvider(std::vector<AlbumInfo>(), folders));
- TestPicasaFileUtil file_util(data_provider.Pass());
-
- scoped_ptr<FileSystemFileUtil::AbstractFileEnumerator> file_enumerator =
- file_util.CreateFileEnumerator(operation_context.get(),
- CreateURL("folders"));
-
- for (unsigned int i = 0; i < expected_names.size(); ++i) {
- base::FilePath path = file_enumerator->Next();
-
- ASSERT_TRUE(!path.empty());
- EXPECT_EQ(expected_names[i], path.BaseName().AsUTF8Unsafe());
- EXPECT_EQ(folders[i].timestamp, file_enumerator->LastModifiedTime());
- EXPECT_TRUE(file_enumerator->IsDirectory());
+ chrome::AsyncFileUtilTestHelper test_file_util(
+ new TestPicasaFileUtil(data_provider.Pass()));
+
+ fileapi::AsyncFileUtil::EntryList file_list;
+ bool has_more = false;
+ base::PlatformFileError error = test_file_util.ReadDirectorySync(
+ operation_context.get(),
+ CreateURL(kPicasaDirFolders),
+ &file_list,
+ &has_more);
+ ASSERT_EQ(error, base::PLATFORM_FILE_OK);
+
+ for (size_t i = 0; i < file_list.size(); ++i) {
+ ASSERT_FALSE(file_list[i].name.empty());
+ EXPECT_EQ(expected_names[i],
+ base::FilePath(file_list[i].name).AsUTF8Unsafe());
+ EXPECT_EQ(folders[i].timestamp, file_list[i].last_modified_time);
+ EXPECT_TRUE(file_list[i].is_directory);
}
}

Powered by Google App Engine
This is Rietveld 408576698