chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.h - Issue 15653004: Picasa import: Make NativeMediaFileUtil an AsyncFileUtil

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.h

Issue 15653004: Picasa import: Make NativeMediaFileUtil an AsyncFileUtil (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Win fix Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/fileapi/async_file_util_test_helper.h ('K') | « chrome/browser/media_galleries/fileapi/filtering_file_enumerator.cc ('k') | chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.cc » ('j') | chrome/browser/media_galleries/fileapi/native_media_file_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.h

diff --git a/chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.h b/chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.h

index c4e1349b8cbdce4d13de0b28295a20cbd7a572c1..1057a5366e870e47b2d3b0eec7e0797ec7ef1dae 100644

--- a/chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.h

+++ b/chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.h

@@ -14,18 +14,16 @@ class ItunesFileUtil : public chrome::NativeMediaFileUtil {

ItunesFileUtil();

virtual ~ItunesFileUtil();

- // Overrides from NativeMediaFileUtil

- virtual base::PlatformFileError GetFileInfo(

+ protected:

Lei Zhang 2013/05/30 21:17:58 This can be private: instead?

tommycli 2013/05/30 21:52:32 Done.

+ virtual base::PlatformFileError GetFileInfoSync(

Lei Zhang 2013/05/30 21:17:58 Preserve the comment indicating what this is overr

tommycli 2013/05/30 21:52:32 Done.

fileapi::FileSystemOperationContext* context,

const fileapi::FileSystemURL& url,

base::PlatformFileInfo* file_info,

base::FilePath* platform_path) OVERRIDE;

- // Paths are enumerated in lexicographical order.

- virtual scoped_ptr<AbstractFileEnumerator> CreateFileEnumerator(

+ virtual base::PlatformFileError ReadDirectorySync(

fileapi::FileSystemOperationContext* context,

- const fileapi::FileSystemURL& url) OVERRIDE;

+ const fileapi::FileSystemURL& url,

+ EntryList* file_list) OVERRIDE;

virtual base::PlatformFileError GetLocalFilePath(

fileapi::FileSystemOperationContext* context,

const fileapi::FileSystemURL& url,