Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1565283003: More <type_traits> for SkTLogic.h. (Closed)

Created:
4 years, 11 months ago by bungeman-skia
Modified:
4 years, 11 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More <type_traits> for SkTLogic.h. SkTLogic.h specifies a number of declarations now found in <type_traits>. This removes some of these declarations from SkTLogic.h in favor of the ::std versions. These declarations are fairly safe to change as the implementations are striaght forward and no known stl implementations are known to have issues with them. Committed: https://skia.googlesource.com/skia/+/de029d0e41d2acb3cf49bd0d64b91add1aae9bd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -50 lines) Patch
M include/private/SkTLogic.h View 5 chunks +14 lines, -39 lines 0 comments Download
M include/private/SkUniquePtr.h View 4 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565283003/1
4 years, 11 months ago (2016-01-07 20:17:07 UTC) #4
bungeman-skia
4 years, 11 months ago (2016-01-07 20:22:57 UTC) #6
mtklein
lgtm
4 years, 11 months ago (2016-01-07 20:32:39 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-07 20:35:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565283003/1
4 years, 11 months ago (2016-01-07 20:38:32 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 20:39:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/de029d0e41d2acb3cf49bd0d64b91add1aae9bd6

Powered by Google App Engine
This is Rietveld 408576698