Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: pkg/analyzer/tool/summary/idl.dart

Issue 1565283002: Add uriOffset and uriEnd to the summary. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/summary/summary_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/tool/summary/idl.dart
diff --git a/pkg/analyzer/tool/summary/idl.dart b/pkg/analyzer/tool/summary/idl.dart
index 939c4861edad558fb0169cd6b91b5917f2df7020..0b3d3e26dc3f93991881e2b31c94caba87845995 100644
--- a/pkg/analyzer/tool/summary/idl.dart
+++ b/pkg/analyzer/tool/summary/idl.dart
@@ -406,9 +406,30 @@ enum UnlinkedExecutableKind {
}
/**
- * Unlinked summary information about an export declaration.
+ * Unlinked summary information about an export declaration (stored outside
+ * [UnlinkedPublicNamespace]).
*/
-class UnlinkedExport {
+class UnlinkedExportNonPublic {
+ /**
+ * Offset of the URI string (including quotes) relative to the beginning of
+ * the file.
+ */
+ @informative
+ int uriOffset;
+
+ /**
+ * End of the URI string (including quotes) relative to the beginning of the
+ * file.
+ */
+ @informative
+ int uriEnd;
+}
+
+/**
+ * Unlinked summary information about an export declaration (stored inside
+ * [UnlinkedPublicNamespace]).
+ */
+class UnlinkedExportPublic {
/**
* URI used in the source code to reference the exported library.
*/
@@ -458,6 +479,20 @@ class UnlinkedImport {
* Indicates whether the import declaration is implicit.
*/
bool isImplicit;
+
+ /**
+ * Offset of the URI string (including quotes) relative to the beginning of
+ * the file. If [isImplicit] is true, zero.
+ */
+ @informative
+ int uriOffset;
+
+ /**
+ * End of the URI string (including quotes) relative to the beginning of the
+ * file. If [isImplicit] is true, zero.
+ */
+ @informative
+ int uriEnd;
}
/**
@@ -531,9 +566,18 @@ enum UnlinkedParamKind {
*/
class UnlinkedPart {
/**
- * String used in the compilation unit to refer to the part file.
+ * Offset of the URI string (including quotes) relative to the beginning of
+ * the file.
*/
- String uri;
+ @informative
+ int uriOffset;
+
+ /**
+ * End of the URI string (including quotes) relative to the beginning of the
+ * file.
+ */
+ @informative
+ int uriEnd;
}
/**
@@ -586,12 +630,12 @@ class UnlinkedPublicNamespace {
/**
* Export declarations in the compilation unit.
*/
- List<UnlinkedExport> exports;
+ List<UnlinkedExportPublic> exports;
/**
- * Part declarations in the compilation unit.
+ * URIs referenced by part declarations in the compilation unit.
*/
- List<UnlinkedPart> parts;
+ List<String> parts;
}
/**
@@ -736,11 +780,21 @@ class UnlinkedUnit {
List<UnlinkedExecutable> executables;
/**
+ * Export declarations in the compilation unit.
+ */
+ List<UnlinkedExportNonPublic> exports;
+
+ /**
* Import declarations in the compilation unit.
*/
List<UnlinkedImport> imports;
/**
+ * Part declarations in the compilation unit.
+ */
+ List<UnlinkedPart> parts;
+
+ /**
* Typedefs declared in the compilation unit.
*/
List<UnlinkedTypedef> typedefs;
« no previous file with comments | « pkg/analyzer/test/src/summary/summary_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698