Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1565283002: Add uriOffset and uriEnd to the summary. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -71 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 26 chunks +218 lines, -33 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 9 chunks +29 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 3 chunks +24 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 5 chunks +25 lines, -1 line 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 5 chunks +61 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-07 19:48:39 UTC) #2
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-07 20:41:14 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-07 20:55:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f6a8f29ef00a6f41fb48c038df72057b6512ff0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698