Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Issue 1565243002: Fixes bug where client area would not get set correctly (Closed)

Created:
4 years, 11 months ago by sky
Modified:
4 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes bug where client area would not get set correctly The client area is updated when the bounds change, further to correctly calculate the client area the NonClientView has to have been created. Prior to this fix if the window was sized during InitNativeWidget() and never changed after that, then the client area was not correctly set because during InitNativeWidget() the NonClientView has not been created. The fix is to add a NativeWidgetPrivate function that Widget calls after it has created the NonClientView. BUG=none TEST=none R=erg@chromium.org Committed: https://crrev.com/161fa4146ef4b619df2210317a31c3a6b1670b5c Cr-Commit-Position: refs/heads/master@{#368141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M ui/views/mus/native_widget_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/views/widget/android/native_widget_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/android/native_widget_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_private.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 11 months ago (2016-01-07 19:28:18 UTC) #1
Elliot Glaysher
lgtm
4 years, 11 months ago (2016-01-07 20:05:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565243002/1
4 years, 11 months ago (2016-01-07 20:07:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 20:17:06 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 20:19:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/161fa4146ef4b619df2210317a31c3a6b1670b5c
Cr-Commit-Position: refs/heads/master@{#368141}

Powered by Google App Engine
This is Rietveld 408576698