Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1565203002: Revert of add backdrop option to SaveLayerRec (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of add backdrop option to SaveLayerRec (patchset #14 id:260001 of https://codereview.chromium.org/1523053003/ ) Reason for revert: serialized != direct, will investigate Original issue's description: > add backdrop option to SaveLayerRec > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1523053003 > > Committed: https://skia.googlesource.com/skia/+/247415969a9a5ed6c83cc09395472416c4b7de7f TBR=robertphillips@google.com,bsalomon@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0575cb2def2f4dfdad04e0674d0f8eb8e7c24cec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -256 lines) Patch
M gm/imagefilters.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +5 lines, -16 lines 0 comments Download
M include/private/SkRecords.h View 2 chunks +0 lines, -2 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 chunk +2 lines, -74 lines 0 comments Download
M src/core/SkCanvas.cpp View 5 chunks +8 lines, -10 lines 0 comments Download
M src/core/SkPictureFlat.h View 2 chunks +3 lines, -11 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +1 line, -19 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 2 chunks +12 lines, -38 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of add backdrop option to SaveLayerRec
4 years, 11 months ago (2016-01-07 16:14:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565203002/1
4 years, 11 months ago (2016-01-07 16:15:07 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 16:15:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0575cb2def2f4dfdad04e0674d0f8eb8e7c24cec

Powered by Google App Engine
This is Rietveld 408576698