Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1565193002: [arm64] Add assertions to Claim and Drop. (Closed)

Created:
4 years, 11 months ago by jbramley
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Add assertions to Claim and Drop. In particular, Claim doesn't work with a negative size, so ensure that it is positive. BUG= Committed: https://crrev.com/4938aca2c27134c79926d2a6c093ebf658f8fbf3 Cr-Commit-Position: refs/heads/master@{#33198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M src/arm64/macro-assembler-arm64.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
This would have caught the problem in https://codereview.chromium.org/1537903004/ slightly earlier.
4 years, 11 months ago (2016-01-07 15:48:00 UTC) #2
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-08 06:22:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565193002/1
4 years, 11 months ago (2016-01-11 10:02:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 10:26:13 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 10:27:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4938aca2c27134c79926d2a6c093ebf658f8fbf3
Cr-Commit-Position: refs/heads/master@{#33198}

Powered by Google App Engine
This is Rietveld 408576698