Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1565183003: X87: [TurboFan] Fixed the kX87BitcastFI and kX87BitcastIF code generation bugs. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [TurboFan] Fixed the kX87BitcastFI and kX87BitcastIF code generation bugs. The original kX87BitcastFI and kX87BitcastIF of x87 code generation in TurboFan have bugs and caused all Run_Wasm_F32CopySign test cases failed. This CL will fix them. BUG= Committed: https://crrev.com/30cf31ea5a714862afaf886f0301180ad7ba7903 Cr-Commit-Position: refs/heads/master@{#33166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, Thanks!
4 years, 11 months ago (2016-01-08 02:06:59 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-08 02:20:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565183003/1
4 years, 11 months ago (2016-01-08 02:20:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 02:41:28 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 02:41:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30cf31ea5a714862afaf886f0301180ad7ba7903
Cr-Commit-Position: refs/heads/master@{#33166}

Powered by Google App Engine
This is Rietveld 408576698