Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1565183002: [regexp] move regexp parser into own files. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] move regexp parser into own files. R=rossberg@chromium.org, ulan@chromium.org Committed: https://crrev.com/0a808704c9ddd38507041e97b48bd015ab89b41a Cr-Commit-Position: refs/heads/master@{#33169}

Patch Set 1 #

Patch Set 2 : fix test compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2289 lines, -2218 lines) Patch
M BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ast/ast.h View 3 chunks +0 lines, -365 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +0 lines, -330 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +0 lines, -258 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +0 lines, -1110 lines 0 comments Download
M src/parsing/scanner.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/regexp/jsregexp.h View 4 chunks +1 line, -141 lines 0 comments Download
M src/regexp/jsregexp.cc View 1 chunk +1 line, -1 line 0 comments Download
A src/regexp/regexp-ast.h View 1 chunk +496 lines, -0 lines 0 comments Download
A src/regexp/regexp-ast.cc View 1 chunk +337 lines, -0 lines 0 comments Download
M src/regexp/regexp-macro-assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
A src/regexp/regexp-parser.h View 1 chunk +276 lines, -0 lines 0 comments Download
A src/regexp/regexp-parser.cc View 1 chunk +1154 lines, -0 lines 0 comments Download
M src/utils.h View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Yang
Ulan, please review src/heap. Andreas, please review the rest (it's all mechanical, moving around code ...
4 years, 11 months ago (2016-01-07 14:39:28 UTC) #1
rossberg
lgtm
4 years, 11 months ago (2016-01-07 14:49:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565183002/1
4 years, 11 months ago (2016-01-07 15:04:46 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/8647) v8_win_rel_ng on ...
4 years, 11 months ago (2016-01-07 15:10:17 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565183002/20001
4 years, 11 months ago (2016-01-08 09:28:09 UTC) #8
Hannes Payer (out of office)
heap lgtm
4 years, 11 months ago (2016-01-08 09:28:57 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 09:51:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565183002/20001
4 years, 11 months ago (2016-01-08 09:53:56 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-08 09:55:35 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 09:56:12 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a808704c9ddd38507041e97b48bd015ab89b41a
Cr-Commit-Position: refs/heads/master@{#33169}

Powered by Google App Engine
This is Rietveld 408576698