Don't send touch events to windows like menus when the touch occurs outside the menu bounds.

ui/aura/window_event_dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/window_event_dispatcher.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 82 matching lines @@
   ui::GestureRecognizer::Get()->AddGestureEventHelper(this);
   Env::GetInstance()->AddObserver(this);
 }
 
 WindowEventDispatcher::~WindowEventDispatcher() {
   TRACE_EVENT0("shutdown", "WindowEventDispatcher::Destructor");
   Env::GetInstance()->RemoveObserver(this);
   ui::GestureRecognizer::Get()->RemoveGestureEventHelper(this);
 }
 
-void WindowEventDispatcher::RepostEvent(const ui::LocatedEvent& event) {
-  DCHECK(event.type() == ui::ET_MOUSE_PRESSED ||
-         event.type() == ui::ET_GESTURE_TAP_DOWN);
+void WindowEventDispatcher::RepostEvent(const ui::LocatedEvent* event) {
+  DCHECK(event->type() == ui::ET_MOUSE_PRESSED ||
+         event->type() == ui::ET_GESTURE_TAP_DOWN ||
+         event->type() == ui::ET_TOUCH_PRESSED);
   // We allow for only one outstanding repostable event. This is used
   // in exiting context menus.  A dropped repost request is allowed.
-  if (event.type() == ui::ET_MOUSE_PRESSED) {
-    held_repostable_event_.reset(
-        new ui::MouseEvent(
-            static_cast<const ui::MouseEvent&>(event),
-            static_cast<aura::Window*>(event.target()),
-            window()));
+  if ((event->type() == ui::ET_MOUSE_PRESSED) ||
+      (event->type() == ui::ET_TOUCH_PRESSED)) {
+    if (event->type() == ui::ET_MOUSE_PRESSED) {
+      held_repostable_event_.reset(
+          new ui::MouseEvent(
+              static_cast<const ui::MouseEvent&>(*event),
+              static_cast<aura::Window*>(event->target()),
+              window()));
+    } else {
+      held_repostable_event_.reset(
+          new ui::TouchEvent(static_cast<const ui::TouchEvent&>(*event)));
+    }
     base::MessageLoop::current()->PostNonNestableTask(
         FROM_HERE, base::Bind(
             base::IgnoreResult(&WindowEventDispatcher::DispatchHeldEvents),
             repost_event_factory_.GetWeakPtr()));
   } else {
-    DCHECK(event.type() == ui::ET_GESTURE_TAP_DOWN);
+    DCHECK(event->type() == ui::ET_GESTURE_TAP_DOWN);
     held_repostable_event_.reset();
     // TODO(rbyers): Reposing of gestures is tricky to get
     // right, so it's not yet supported.  crbug.com/170987.
   }
 }

[sadrul, 2016/01/13 20:24:24]

Can this be like:

  if (event->type() == ui::ET_MOUSE_PRESSED) {
    ...
  } else if (event->type() == ui::ET_TOUCH_PRESSED) {
    ...
  } else {
    DCHECK_EQ(ui::ET_GESTURE_TAP_DOWN, event->type());
    ...
  }

  if (held_repostable_event_) {
    ... post task
  }

[ananta, 2016/01/13 21:34:48]

Done.

 
 void WindowEventDispatcher::OnMouseEventsEnableStateChanged(bool enabled) {
   // Send entered / exited so that visual state can be updated to match
   // mouse events state.
   PostSynthesizeMouseMove();
   // TODO(mazda): Add code to disable mouse events when |enabled| == false.
 }
 
 void WindowEventDispatcher::DispatchCancelModeEvent() {
   ui::CancelModeEvent event;
@@ skipping 524 matching lines @@
 // WindowEventDispatcher, private:
 
 ui::EventDispatchDetails WindowEventDispatcher::DispatchHeldEvents() {
   if (!held_repostable_event_ && !held_move_event_)
     return DispatchDetails();
 
   CHECK(!dispatching_held_event_);
 
   DispatchDetails dispatch_details;
   if (held_repostable_event_) {
-    if (held_repostable_event_->type() == ui::ET_MOUSE_PRESSED) {
-      scoped_ptr<ui::MouseEvent> mouse_event(
-          static_cast<ui::MouseEvent*>(held_repostable_event_.release()));
-      dispatching_held_event_ = mouse_event.get();
-      dispatch_details = OnEventFromSource(mouse_event.get());
+    if (held_repostable_event_->type() == ui::ET_MOUSE_PRESSED ||
+        held_repostable_event_->type() == ui::ET_TOUCH_PRESSED) {
+      scoped_ptr<ui::LocatedEvent> event;
+      event.reset(held_repostable_event_.release());

[sadrul, 2016/01/13 20:24:24]

Use std::move instead?

[ananta, 2016/01/13 21:34:48]

done

+      dispatching_held_event_ = event.get();
+      dispatch_details = OnEventFromSource(event.get());
     } else {
       // TODO(rbyers): GESTURE_TAP_DOWN not yet supported: crbug.com/170987.
       NOTREACHED();
     }
     if (dispatch_details.dispatcher_destroyed)
       return dispatch_details;
   }
 
   if (held_move_event_) {
     // If a mouse move has been synthesized, the target location is suspect,
@@ skipping 224 matching lines @@
   }
 
   // This flag is set depending on the gestures recognized in the call above,
   // and needs to propagate with the forwarded event.
   event->set_may_cause_scrolling(orig_event.may_cause_scrolling());
 
   return PreDispatchLocatedEvent(target, event);
 }
 
 }  // namespace aura