Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1768)

Unified Diff: Source/core/rendering/AutoTableLayout.cpp

Issue 15650011: Modifying shouldScaleColumns for proper scaling of nested table columns Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/AutoTableLayout.cpp
diff --git a/Source/core/rendering/AutoTableLayout.cpp b/Source/core/rendering/AutoTableLayout.cpp
index 52172d2c4541b20e988680a6c3b58d4c6cd08030..81c2346f35f9af9bb56a6b19bf8a8ada7eb45747 100644
--- a/Source/core/rendering/AutoTableLayout.cpp
+++ b/Source/core/rendering/AutoTableLayout.cpp
@@ -198,7 +198,9 @@ static bool shouldScaleColumns(RenderTable* table)
if (cb && cb->isTableCell() &&
(cb->style()->width().isAuto() || cb->style()->width().isPercent())) {
RenderTableCell* cell = toRenderTableCell(cb);
- if (cell->colSpan() > 1 || cell->table()->style()->width().isAuto())
+ Length tableWidth = cell->table()->style()->width();
+ if (cell->colSpan() > 1 || tableWidth.isAuto() || (tableWidth.isSpecified() && tableWidth.isZero())
+ || cell->table()->isFloatingOrOutOfFlowPositioned())
Julien - ping for review 2013/05/29 20:56:14 How about some testing for these cases?
scale = false;
else
table = cell->table();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698