Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 15650011: Modifying shouldScaleColumns for proper scaling of nested table columns

Created:
7 years, 7 months ago by arpitab
Modified:
5 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Modifying shouldScaleColumns for proper scaling of nested table columns. For scenarios where the containing table width is of percent or fixed type, but with width specified as either 0px or 0%, scaling of the nested or inner table columns is still allowed. Also, if the containing table was floated or positioned, we would still allow scaling of the nested table's columns. We should consider a specified width value of either 0px or 0%, similar in behavior to an auto width and disallow the scaling of nested columns for that case. Similarly, if the containing table is either floated or positioned, we should again disallow the scaling of its nested table's columns. R=jchaffraix@chromium.org BUG=244182

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/core/rendering/AutoTableLayout.cpp View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
Julien - ping for review
Sorry for the delay, catching up on reviews after gardening. https://codereview.chromium.org/15650011/diff/1/Source/core/rendering/AutoTableLayout.cpp File Source/core/rendering/AutoTableLayout.cpp (right): https://codereview.chromium.org/15650011/diff/1/Source/core/rendering/AutoTableLayout.cpp#newcode203 ...
7 years, 6 months ago (2013-05-29 20:56:14 UTC) #1
eae
5 years, 5 months ago (2015-07-14 22:39:59 UTC) #2
Ping? What's the status on this, ideally we'd like to fix this issue...

Powered by Google App Engine
This is Rietveld 408576698