Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15650008: drive: Rename drive::DriveClientContext to drive::ClientContext (Closed)

Created:
7 years, 7 months ago by satorux1
Modified:
7 years, 6 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Rename drive::DriveClientContext to drive::ClientContext The original name was redundant. BUG=242121 TEST=none R=hashimoto@chromium.org, jhawkins@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202774

Patch Set 1 #

Total comments: 8

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -70 lines) Patch
M chrome/browser/chromeos/drive/dummy_file_system.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_file_operation.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operations.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operations.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/update_operation.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/update_operation.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_interface.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.h View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler_unittest.cc View 1 2 3 10 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/drive/mock_file_system.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/screenshot_source.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
satorux1
hashimoto@ for everything jhawkins@ for chrome/browser/ui/webui/screenshot_source.cc
7 years, 7 months ago (2013-05-27 01:06:07 UTC) #1
hashimoto
lgtm https://codereview.chromium.org/15650008/diff/1/chrome/browser/chromeos/drive/file_system/drive_operations.h File chrome/browser/chromeos/drive/file_system/drive_operations.h (right): https://codereview.chromium.org/15650008/diff/1/chrome/browser/chromeos/drive/file_system/drive_operations.h#newcode123 chrome/browser/chromeos/drive/file_system/drive_operations.h:123: ClientContext context, nit: Could you fix this to ...
7 years, 7 months ago (2013-05-27 03:04:38 UTC) #2
satorux1
https://codereview.chromium.org/15650008/diff/1/chrome/browser/chromeos/drive/file_system/drive_operations.h File chrome/browser/chromeos/drive/file_system/drive_operations.h (right): https://codereview.chromium.org/15650008/diff/1/chrome/browser/chromeos/drive/file_system/drive_operations.h#newcode123 chrome/browser/chromeos/drive/file_system/drive_operations.h:123: ClientContext context, On 2013/05/27 03:04:39, hashimoto wrote: > nit: ...
7 years, 7 months ago (2013-05-27 03:36:11 UTC) #3
hashimoto
lgtm
7 years, 7 months ago (2013-05-27 03:47:16 UTC) #4
satorux1
+thestig in case james is away. please take a look at chrome/browser/ui/webui/screenshot_source.cc, which is just ...
7 years, 6 months ago (2013-05-29 00:53:54 UTC) #5
James Hawkins
lgtm
7 years, 6 months ago (2013-05-29 00:55:08 UTC) #6
satorux1
7 years, 6 months ago (2013-05-29 04:15:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 manually as r202774 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698