Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: media/base/stream_parser.h

Issue 1564983003: MSE: Log a warning if muxed AV media segment has no A or has no V block (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed previous CR comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/chunk_demuxer_unittest.cc » ('j') | media/filters/chunk_demuxer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/stream_parser.h
diff --git a/media/base/stream_parser.h b/media/base/stream_parser.h
index 27ebc3f0a59190ba83719fe179834eadd41baccd..11740c9d1c6eeb9c67dce7d34de271b3a1c9e99b 100644
--- a/media/base/stream_parser.h
+++ b/media/base/stream_parser.h
@@ -106,6 +106,9 @@ class MEDIA_EXPORT StreamParser {
// Signals the beginning of a new media segment.
typedef base::Callback<void()> NewMediaSegmentCB;
+ // Signals the end of a media segment.
+ typedef base::Callback<void()> EndMediaSegmentCB;
+
// A new potentially encrypted stream has been parsed.
// First parameter - The type of the initialization data associated with the
// stream.
@@ -128,12 +131,13 @@ class MEDIA_EXPORT StreamParser {
bool ignore_text_track,
const EncryptedMediaInitDataCB& encrypted_media_init_data_cb,
const NewMediaSegmentCB& new_segment_cb,
- const base::Closure& end_of_segment_cb,
+ const EndMediaSegmentCB& end_of_segment_cb,
const scoped_refptr<MediaLog>& media_log) = 0;
- // Called when a seek occurs. This flushes the current parser state
- // and puts the parser in a state where it can receive data for the new seek
- // point.
+ // Called during the reset parser state algorithm. This flushes the current
+ // parser and puts the parser in a state where it can receive data. This
+ // method does not need to invoke the EndMediaSegmentCB since the parser reset
+ // algorithm already resets the segment parsing state.
virtual void Flush() = 0;
// Called when there is new data to parse.
« no previous file with comments | « no previous file | media/filters/chunk_demuxer_unittest.cc » ('j') | media/filters/chunk_demuxer_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698