Don't center screen magnification on empty focus rectangle

Don't center screen magnification on empty focus rectangle

BUG=574951
TEST=On OOBE or login screen, turn on screen magnifier, then click on
blank parts of page.  Magnification shouldn't move to upper left of
screen.

Committed: https://crrev.com/0043bf421a4ff6c3be3564a77d4d51b10a467f05
Cr-Commit-Position: refs/heads/master@{#368443}

[Greg Levin, 2016-01-06 23:05:30]

glevin@chromium.org changed reviewers:
+ jennyz@chromium.org, oshima@chromium.org

[Greg Levin, 2016-01-06 23:05:30]

oshima@ : owner
jennyz@ : magnifier expert
Please have a look!

jennyz@ -  In the instance of this bug, the node_bounds_in_screen argument for
HandleFocusedNodeChanged() was (0, 0, 0, 0).  I'm not sure if nothing has focus
here, or if there's a problem getting the bounds of the whole screen, but not
recentering on empty rectangles seems like a good fix regardless.

[oshima, 2016-01-07 00:27:19]

can you add a unit test?

[Greg Levin, 2016-01-07 18:18:48]

Unit test added.

[oshima, 2016-01-07 18:22:56]

lgtm, but please wait for jennyz@'s review.

[jennyz, 2016-01-08 19:41:34]

lgtm

[Greg Levin, 2016-01-08 20:28:31]

The CQ bit was checked by glevin@chromium.org

[commit-bot: I haz the power, 2016-01-08 20:28:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564973002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564973002/20001

[commit-bot: I haz the power, 2016-01-08 22:05:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-08 22:06:06]

Description was changed from

==========
Don't center screen magnification on empty focus rectangle

BUG=574951
TEST=On OOBE or login screen, turn on screen magnifier, then click on
blank parts of page.  Magnification shouldn't move to upper left of
screen.
==========

to

==========
Don't center screen magnification on empty focus rectangle

BUG=574951
TEST=On OOBE or login screen, turn on screen magnifier, then click on
blank parts of page.  Magnification shouldn't move to upper left of
screen.

Committed: https://crrev.com/0043bf421a4ff6c3be3564a77d4d51b10a467f05
Cr-Commit-Position: refs/heads/master@{#368443}
==========

[commit-bot: I haz the power, 2016-01-08 22:06:07]

Patchset 2 (id:??) landed as
https://crrev.com/0043bf421a4ff6c3be3564a77d4d51b10a467f05
Cr-Commit-Position: refs/heads/master@{#368443}