Add the ability to show a demo app on OOBE if a machine is derelict.

chrome/browser/chromeos/idle_detector.h

Index: chrome/browser/chromeos/idle_detector.h
diff --git a/chrome/browser/chromeos/idle_detector.h b/chrome/browser/chromeos/idle_detector.h
new file mode 100644
index 0000000000000000000000000000000000000000..e585c405491654f480856e1020ad7ab8381837e0
--- /dev/null
+++ b/chrome/browser/chromeos/idle_detector.h
@@ -0,0 +1,42 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_IDLE_DETECTOR_H_
+#define CHROME_BROWSER_CHROMEOS_IDLE_DETECTOR_H_
+
+#include "ash/wm/user_activity_observer.h"
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "base/timer/timer.h"
+
+namespace chromeos {
+
+class IdleDetector : public ash::UserActivityObserver {

[bartfab (slow), 2014/02/13 19:51:53]

The location and name of this file imply that it is something very generic.
However, doing idle detection inside Chrome like this is a hack that should not
be used in the general case. The correct place for idle detection is powerd,
which can be configured to take into account other signals, such as audio and
video activity.

At the very least, the class should be renamed and a comment should be added
that explains it is not meant to be used in the general case that idleness needs
to be determined.

[rkc, 2014/02/13 23:22:01]

UserActivityDetector is used multiple places in the code to detect idle
behavior. When I originally wrote the code for the idle logout detector, I did
use power manager to detect idle behavior but at that time derat@ had suggested
that we should use the UserActivityDetector instead.

If this is not the ideal way to detect user active/idle state anymore, I'll
discuss the new correct way with derat@ and get it in a separate CL. This code
currently works for our purposes (unless someone decides to play a video on
OOBE, which I am hoping won't happen in M34?) and it isn't a good idea to change
this code significantly before M34 branches on Monday.

I've created a bug and added a comment to address this in M35.

+ public:
+  IdleDetector(const base::Closure& on_active_callback,

[bartfab (slow), 2014/02/13 19:51:53]

What is |on_active_callback| meant for? Nobody ever uses it.

[rkc, 2014/02/13 23:22:01]

This code is entirely reusable for the idle_logout dialog code in retail mode,
provided we also have an on_active callback. I intend to use this class for that
code but wouldn't like to refactor this class again when I do.

[bartfab (slow), 2014/02/17 15:53:46]

As discussed offline, the retail mode idle logout dialog is obsolete and can be
removed very soon (yay!) rather than being refactored. Thus, my comments stand:
This class should be renamed into something that indicates it is a one-shot
implementation for demo mode only and the |on_active_callback| that nobody uses
should be removed.

+               const base::Closure& on_idle_callback);
+  virtual ~IdleDetector();
+
+  void Start(const base::TimeDelta& timeout);
+
+ private:
+  // UserActivityObserver overrides:
+  virtual void OnUserActivity(const ui::Event* event) OVERRIDE;
+
+  // Resets |timer_| to fire when we reach our idle timeout.
+  void ResetTimer();
+
+  base::OneShotTimer<IdleDetector> timer_;
+
+  base::Closure active_callback_;

[bartfab (slow), 2014/02/13 19:51:53]

Nit: #include "base/callback.h"

[rkc, 2014/02/13 23:22:01]

Done.

+  base::Closure idle_callback_;
+
+  base::TimeDelta timeout_;

[bartfab (slow), 2014/02/13 19:51:53]

Nit: #include "base/time.h"

[rkc, 2014/02/13 23:22:01]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(IdleDetector);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_IDLE_DETECTOR_H_