chrome/browser/resources/chromeos/demo_app/manifest.json - Issue 156493004: Add the ability to show a demo app on OOBE if a machine is derelict.

Side by Side Diff: chrome/browser/resources/chromeos/demo_app/manifest.json

Issue 156493004: Add the ability to show a demo app on OOBE if a machine is derelict. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/chromeos/login/parallel_authenticator.cc ('K') | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/ui/startup/startup_browser_creator.cc » ('j') | chrome/browser/ui/startup/startup_browser_creator.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {
	bartfab (slow) 2014/02/13 19:51:53 I find it strange that we ship the manifest with t I find it strange that we ship the manifest with the Chrome source code and the app separately. Is there any reason that the manifest cannot reside inside /usr/share/chromeos-assets/demo_app so that it gets updated automatically together with the app? rkc 2014/02/13 23:22:01 We're loading this as a component app, not a regul Show quoted text On 2014/02/13 19:51:53, bartfab wrote: > I find it strange that we ship the manifest with the Chrome source code and the > app separately. Is there any reason that the manifest cannot reside inside > /usr/share/chromeos-assets/demo_app so that it gets updated automatically > together with the app? We're loading this as a component app, not a regular app. If we switch to loading this just as a regular app, we can move this manifest out. I am discussing the pros/cons of that with a few folks here before deciding what to do with it in M35. bartfab (slow) 2014/02/17 15:53:46 When loading the app, you specify the path to the Show quoted text On 2014/02/13 23:22:01, Rahul Chaturvedi wrote: > On 2014/02/13 19:51:53, bartfab wrote: > > I find it strange that we ship the manifest with the Chrome source code and > the > > app separately. Is there any reason that the manifest cannot reside inside > > /usr/share/chromeos-assets/demo_app so that it gets updated automatically > > together with the app? > > We're loading this as a component app, not a regular app. If we switch to > loading this just as a regular app, we can move this manifest out. I am > discussing the pros/cons of that with a few folks here before deciding what to > do with it in M35. When loading the app, you specify the path to the manifest. Why would you be unable to load it as a component app if the path pointed to somewhere inside /usr/share/chromeos-assets/demo_app?
	2 // chrome-extension://klimoghijjogocdbaikffefjfcfheiel
	bartfab (slow) 2014/02/13 19:51:53 Comments are not allowed in JSON. This file is inv Comments are not allowed in JSON. This file is invalid. rkc 2014/02/13 23:22:01 Almost every component app manifest in the tree ha Show quoted text On 2014/02/13 19:51:53, bartfab wrote: > Comments are not allowed in JSON. This file is invalid. Almost every component app manifest in the tree has that comment, so I am pretty sure that the manifest parser handles comments fine. bartfab (slow) 2014/02/17 15:53:46 It's still invalid JSON :). Show quoted text On 2014/02/13 23:22:01, Rahul Chaturvedi wrote: > On 2014/02/13 19:51:53, bartfab wrote: > > Comments are not allowed in JSON. This file is invalid. > > Almost every component app manifest in the tree has that comment, so I am pretty > sure that the manifest parser handles comments fine. > It's still invalid JSON :).
	3 "key": "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAqTqJNPnnhAarSbA5aPvPU/h6Bx vHO+PWQLVab5RyJUxl1eVnZFx9sIGoXctUgKG+DXpSflYhsvK7opMd1jPqdeSjeSvIDOlsSNX45G+FhA qPQ7OHDdKboQb86TbE53n4qXYamQcx09VIJhi19mPBdqod6myCrTYjPukKiNwAlIEz6eAQL/++uZnIyR zvkht3aMMSfA2PP1qg0ie9aHE/bTwPec9I1kUIe4dPz4NaI5hKxKoDVk2TC9MNNEUx1YznuZNP6Vr21Z RutaOIiptnz1/QJXVr37EMqKvEwNJ/zGFhk1nNju7hYRTbf55CID94yWY14SevnO1nprEGv8+zAwIDAQ AB",

	4 "name": "Demo App",

	5 "version": "1.0",

	6 "manifest_version": 2,

	7 "description": "ChromeOS Demo App",

	8 "permissions": ["power"],

	9 "app": {

	10 "background": {

	11 "scripts": ["js/launch.js"]

	12 }

	13 }

	14 }

OLD	NEW