Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: src/ast/ast.h

Issue 1564923007: Fix sloppy block-scoped function hoisting with nested zones (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.h
diff --git a/src/ast/ast.h b/src/ast/ast.h
index 27cc667eb11991750796920c77ea7dfe31e5fa9c..f769bd651f5ae36bdedbc80a166719acfc0b7001 100644
--- a/src/ast/ast.h
+++ b/src/ast/ast.h
@@ -3456,7 +3456,7 @@ class AstNodeFactory final BASE_EMBEDDED {
SloppyBlockFunctionStatement* NewSloppyBlockFunctionStatement(
Statement* statement, Scope* scope) {
return new (local_zone_)
adamk 2016/01/07 23:14:31 Don't you need to allocate the statement itself in
Dan Ehrenberg 2016/01/07 23:18:21 Oops, done, looks like I really need to figure out
- SloppyBlockFunctionStatement(local_zone_, statement, scope);
+ SloppyBlockFunctionStatement(parser_zone_, statement, scope);
}
CaseClause* NewCaseClause(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698