content/renderer/manifest/manifest_manager.cc - Issue 1564913003: [DevTools] Shows Manifest file in Sources tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/manifest/manifest_manager.cc

Issue 1564913003: [DevTools] Shows Manifest file in Sources tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Set Manifest URL in error messages. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/manifest/manifest_manager.cc

diff --git a/content/renderer/manifest/manifest_manager.cc b/content/renderer/manifest/manifest_manager.cc

index b35d4a2e73dfe0d55dd11357c98885f2f065012a..b148601cbb3ad8818f6f68fc1b55ca6c873099ba 100644

--- a/content/renderer/manifest/manifest_manager.cc

+++ b/content/renderer/manifest/manifest_manager.cc

@@ -164,6 +164,8 @@ void ManifestManager::OnManifestFetchComplete(

blink::WebConsoleMessage message;

message.level = blink::WebConsoleMessage::LevelError;

message.text = blink::WebString::fromUTF8(msg);

+ message.url =

+ render_frame()->GetWebFrame()->document().manifestURL().string();

render_frame()->GetWebFrame()->addMessageToConsole(message);

}