[DevTools] Shows Manifest file in Sources tab

[DevTools] Shows Manifest file in Sources tab

 - Adds Manifest resource type in Resource.h and RawResource::fetchManifest().
 - Uses RawResource::fetchManifest() in DocumentThreadableLoader.
 - Adds Manifest resource type in InspectorPageAgent.h.
 - Adds Manifest resource type in protocol.json.
 - Changes InspectorPageAgent::cachedResourceType() and resourceTypeJson() to support Manifest resource type.
 - Changes WebInspector.NetworkProject._addResource() to show the manifest file in Sources tab.
 - Changes WebConsoleMessage.h to support url.
 - Changes manifest_manager.cc to pass the manifest url.

demo: https://drive.google.com/file/d/0B6skYAFVnosEN1UzWktHUTRUdUE/view?usp=sharing

BUG=540493
Committed: https://crrev.com/8b7be11ab44ec90256eeb647972f671972787030
Cr-Commit-Position: refs/heads/master@{#368308}

[horo, 2016-01-07 09:56:29]

Description was changed from

==========
[WIP]add Manifest resource type and shows manifest in DevTools

BUG=540493
==========

to

==========
[WIP]add Manifest resource type and shows manifest in DevTools

demo:
https://drive.google.com/file/d/0B6skYAFVnosEN1UzWktHUTRUdUE/view?usp=sharing

BUG=540493
==========

[horo, 2016-01-07 11:03:26]

Description was changed from

==========
[WIP]add Manifest resource type and shows manifest in DevTools

demo:
https://drive.google.com/file/d/0B6skYAFVnosEN1UzWktHUTRUdUE/view?usp=sharing

BUG=540493
==========

to

==========
[DevTools] Shows Manifest file in Sources tab


This:
 - Adds Manifest resource type in Resource.h and RawResource::fetchManifest().
 - Uses RawResource::fetchManifest() in DocumentThreadableLoader.
 - Adds Manifest resource type in InspectorPageAgent.h.
 - Adds Manifest resource type in protocol.json.
 - Changes InspectorPageAgent::cachedResourceType() and resourceTypeJson() to
support Manifest resource type.
 - Changes WebInspector.NetworkProject._addResource() to show the manifest file
in Sources tab.
 - Changes WebConsoleMessage.h to support url.
 - Changes manifest_manager.cc to pass the manifest url.


demo:
https://drive.google.com/file/d/0B6skYAFVnosEN1UzWktHUTRUdUE/view?usp=sharing

BUG=540493
==========

[horo, 2016-01-07 11:03:40]

Description was changed from

==========
[DevTools] Shows Manifest file in Sources tab


This:
 - Adds Manifest resource type in Resource.h and RawResource::fetchManifest().
 - Uses RawResource::fetchManifest() in DocumentThreadableLoader.
 - Adds Manifest resource type in InspectorPageAgent.h.
 - Adds Manifest resource type in protocol.json.
 - Changes InspectorPageAgent::cachedResourceType() and resourceTypeJson() to
support Manifest resource type.
 - Changes WebInspector.NetworkProject._addResource() to show the manifest file
in Sources tab.
 - Changes WebConsoleMessage.h to support url.
 - Changes manifest_manager.cc to pass the manifest url.


demo:
https://drive.google.com/file/d/0B6skYAFVnosEN1UzWktHUTRUdUE/view?usp=sharing

BUG=540493
==========

to

==========
[DevTools] Shows Manifest file in Sources tab

 - Adds Manifest resource type in Resource.h and RawResource::fetchManifest().
 - Uses RawResource::fetchManifest() in DocumentThreadableLoader.
 - Adds Manifest resource type in InspectorPageAgent.h.
 - Adds Manifest resource type in protocol.json.
 - Changes InspectorPageAgent::cachedResourceType() and resourceTypeJson() to
support Manifest resource type.
 - Changes WebInspector.NetworkProject._addResource() to show the manifest file
in Sources tab.
 - Changes WebConsoleMessage.h to support url.
 - Changes manifest_manager.cc to pass the manifest url.


demo:
https://drive.google.com/file/d/0B6skYAFVnosEN1UzWktHUTRUdUE/view?usp=sharing

BUG=540493
==========

[pfeldman, 2016-01-08 01:54:06]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-01-08 01:54:06]

lgtm, but we should follow up with the line and column.

https://codereview.chromium.org/1564913003/diff/20001/content/renderer/manife...
File content/renderer/manifest/manifest_manager.cc (right):

https://codereview.chromium.org/1564913003/diff/20001/content/renderer/manife...
content/renderer/manifest/manifest_manager.cc:163: for (const std::string& msg :
parser.errors()) {
JSONReader actually has the error line and column, but they are not exposed.
It'd be great if we could plumb them all the way - should not be a big deal.

https://codereview.chromium.org/1564913003/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebConsoleMessage.h (right):

https://codereview.chromium.org/1564913003/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebConsoleMessage.h:61: , url(url) { }
You also want the line and column numbers here.

[horo, 2016-01-08 04:15:02]

On 2016/01/08 01:54:06, pfeldman wrote:
> lgtm, but we should follow up with the line and column.
> 
>
https://codereview.chromium.org/1564913003/diff/20001/content/renderer/manife...
> File content/renderer/manifest/manifest_manager.cc (right):
> 
>
https://codereview.chromium.org/1564913003/diff/20001/content/renderer/manife...
> content/renderer/manifest/manifest_manager.cc:163: for (const std::string& msg
:
> parser.errors()) {
> JSONReader actually has the error line and column, but they are not exposed.
> It'd be great if we could plumb them all the way - should not be a big deal.
> 
>
https://codereview.chromium.org/1564913003/diff/20001/third_party/WebKit/publ...
> File third_party/WebKit/public/web/WebConsoleMessage.h (right):
> 
>
https://codereview.chromium.org/1564913003/diff/20001/third_party/WebKit/publ...
> third_party/WebKit/public/web/WebConsoleMessage.h:61: , url(url) { }
> You also want the line and column numbers here.

Thank you.
I will create another CL to pass the line and column.

[horo, 2016-01-08 04:15:46]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-01-08 04:16:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564913003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564913003/20001

[commit-bot: I haz the power, 2016-01-08 04:29:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 04:29:28]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[horo, 2016-01-08 05:11:34]

The CQ bit was checked by horo@chromium.org

[horo, 2016-01-08 05:11:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1564913003/#ps40001
(title: "fix ResourceTypeName()")

[commit-bot: I haz the power, 2016-01-08 05:12:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564913003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564913003/40001

[commit-bot: I haz the power, 2016-01-08 06:06:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 06:06:22]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-01-08 06:38:04]

The CQ bit was checked by horo@chromium.org

[horo, 2016-01-08 06:38:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1564913003/#ps60001
(title: "fix isRawResource")

[commit-bot: I haz the power, 2016-01-08 06:38:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564913003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564913003/60001

[commit-bot: I haz the power, 2016-01-08 07:36:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 07:36:57]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-01-08 09:18:23]

The CQ bit was checked by horo@chromium.org

[horo, 2016-01-08 09:18:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1564913003/#ps80001
(title: "update network-toggle-type-filter-actual.txt")

[commit-bot: I haz the power, 2016-01-08 09:18:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564913003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564913003/80001

[commit-bot: I haz the power, 2016-01-08 10:38:36]

Description was changed from

==========
[DevTools] Shows Manifest file in Sources tab

 - Adds Manifest resource type in Resource.h and RawResource::fetchManifest().
 - Uses RawResource::fetchManifest() in DocumentThreadableLoader.
 - Adds Manifest resource type in InspectorPageAgent.h.
 - Adds Manifest resource type in protocol.json.
 - Changes InspectorPageAgent::cachedResourceType() and resourceTypeJson() to
support Manifest resource type.
 - Changes WebInspector.NetworkProject._addResource() to show the manifest file
in Sources tab.
 - Changes WebConsoleMessage.h to support url.
 - Changes manifest_manager.cc to pass the manifest url.


demo:
https://drive.google.com/file/d/0B6skYAFVnosEN1UzWktHUTRUdUE/view?usp=sharing

BUG=540493
==========

to

==========
[DevTools] Shows Manifest file in Sources tab

 - Adds Manifest resource type in Resource.h and RawResource::fetchManifest().
 - Uses RawResource::fetchManifest() in DocumentThreadableLoader.
 - Adds Manifest resource type in InspectorPageAgent.h.
 - Adds Manifest resource type in protocol.json.
 - Changes InspectorPageAgent::cachedResourceType() and resourceTypeJson() to
support Manifest resource type.
 - Changes WebInspector.NetworkProject._addResource() to show the manifest file
in Sources tab.
 - Changes WebConsoleMessage.h to support url.
 - Changes manifest_manager.cc to pass the manifest url.


demo:
https://drive.google.com/file/d/0B6skYAFVnosEN1UzWktHUTRUdUE/view?usp=sharing

BUG=540493
==========

[commit-bot: I haz the power, 2016-01-08 10:38:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-08 10:39:18]

Description was changed from

==========
[DevTools] Shows Manifest file in Sources tab

 - Adds Manifest resource type in Resource.h and RawResource::fetchManifest().
 - Uses RawResource::fetchManifest() in DocumentThreadableLoader.
 - Adds Manifest resource type in InspectorPageAgent.h.
 - Adds Manifest resource type in protocol.json.
 - Changes InspectorPageAgent::cachedResourceType() and resourceTypeJson() to
support Manifest resource type.
 - Changes WebInspector.NetworkProject._addResource() to show the manifest file
in Sources tab.
 - Changes WebConsoleMessage.h to support url.
 - Changes manifest_manager.cc to pass the manifest url.


demo:
https://drive.google.com/file/d/0B6skYAFVnosEN1UzWktHUTRUdUE/view?usp=sharing

BUG=540493
==========

to

==========
[DevTools] Shows Manifest file in Sources tab

 - Adds Manifest resource type in Resource.h and RawResource::fetchManifest().
 - Uses RawResource::fetchManifest() in DocumentThreadableLoader.
 - Adds Manifest resource type in InspectorPageAgent.h.
 - Adds Manifest resource type in protocol.json.
 - Changes InspectorPageAgent::cachedResourceType() and resourceTypeJson() to
support Manifest resource type.
 - Changes WebInspector.NetworkProject._addResource() to show the manifest file
in Sources tab.
 - Changes WebConsoleMessage.h to support url.
 - Changes manifest_manager.cc to pass the manifest url.

demo:
https://drive.google.com/file/d/0B6skYAFVnosEN1UzWktHUTRUdUE/view?usp=sharing

BUG=540493

Committed: https://crrev.com/8b7be11ab44ec90256eeb647972f671972787030
Cr-Commit-Position: refs/heads/master@{#368308}
==========

[commit-bot: I haz the power, 2016-01-08 10:39:19]

Patchset 5 (id:??) landed as
https://crrev.com/8b7be11ab44ec90256eeb647972f671972787030
Cr-Commit-Position: refs/heads/master@{#368308}