HeaderValues: Handle all parameters without values.

HeaderValues: Handle all parameters without values.

Some cases, an HttpHeader Value may contain all parameters and
no values. This changes ensures that such a header is parsed, that
it is handled correctly.

This was noticed when parsing the following header for websockets:
Sec-WebSocket-Extensions: permessage-deflate; client_no_context_takeover; client_max_window_bits; server_no_context_takeover

It was parsing with the value permessage-deflate (correct) with parameters:
{'client_no_context_takeover;' : 'client_max_window_bits', 
'server_no_context_takeover' : null }

With this patch it now properly shows the parameters as:
{'client_no_context_takeover' : null, 
'client_max_window_bits' : null,
'server_no_context_takeover' : null }

I've also included a test for this as well.

BUG=

Patch by Matthew Butler <butler.matthew@gmail.com>;.

Committed: https://github.com/dart-lang/sdk/commit/eaf75a100e8fe547c3ad60f8618f15fbf6a3a9dc

[butlermatt, 2016-01-06 20:47:07]

Description was changed from

==========
HeaderValues: Handle all parameters without values.

Some cases, an HttpHeader Value may contain all parameters and
no values. This changes ensures that such a header is parsed, that
it is handled correctly.

BUG=
==========

to

==========
HeaderValues: Handle all parameters without values.

Some cases, an HttpHeader Value may contain all parameters and
no values. This changes ensures that such a header is parsed, that
it is handled correctly.

This was noticed when parsing the following header for websockets:
Sec-WebSocket-Extensions: permessage-deflate; client_no_context_takeover;
client_max_window_bits; server_no_context_takeover

It was parsing with the value permessage-deflate (correct) with parameters:
{'client_no_context_takeover;' : 'client_max_window_bits', 
'server_no_context_takeover' : null }

With this patch it now properly shows the parameters as:
{'client_no_context_takeover' : null, 
'client_max_window_bits' : null,
'server_no_context_takeover' : null }

I've also included a test for this as well.

BUG=
==========

[butlermatt, 2016-01-06 20:47:07]

butler.matthew@gmail.com changed reviewers:
+ sgjesse@google.com

[butlermatt, 2016-01-06 20:48:40]

While diagnosing Websocket compression issues, I became aware of an issue with
the HeaderValue parsing. Sending as a separate CL since it's not specifically
related to the other changes in Websockets.

[Søren Gjesse, 2016-01-07 08:03:36]

Description was changed from

==========
HeaderValues: Handle all parameters without values.

Some cases, an HttpHeader Value may contain all parameters and
no values. This changes ensures that such a header is parsed, that
it is handled correctly.

This was noticed when parsing the following header for websockets:
Sec-WebSocket-Extensions: permessage-deflate; client_no_context_takeover;
client_max_window_bits; server_no_context_takeover

It was parsing with the value permessage-deflate (correct) with parameters:
{'client_no_context_takeover;' : 'client_max_window_bits', 
'server_no_context_takeover' : null }

With this patch it now properly shows the parameters as:
{'client_no_context_takeover' : null, 
'client_max_window_bits' : null,
'server_no_context_takeover' : null }

I've also included a test for this as well.

BUG=
==========

to

==========
HeaderValues: Handle all parameters without values.

Some cases, an HttpHeader Value may contain all parameters and
no values. This changes ensures that such a header is parsed, that
it is handled correctly.

This was noticed when parsing the following header for websockets:
Sec-WebSocket-Extensions: permessage-deflate; client_no_context_takeover;
client_max_window_bits; server_no_context_takeover

It was parsing with the value permessage-deflate (correct) with parameters:
{'client_no_context_takeover;' : 'client_max_window_bits', 
'server_no_context_takeover' : null }

With this patch it now properly shows the parameters as:
{'client_no_context_takeover' : null, 
'client_max_window_bits' : null,
'server_no_context_takeover' : null }

I've also included a test for this as well.

BUG=

Patch by Matthew Butler <butler.matthew@gmail.com>.
==========

[Søren Gjesse, 2016-01-07 08:04:01]

Description was changed from

==========
HeaderValues: Handle all parameters without values.

Some cases, an HttpHeader Value may contain all parameters and
no values. This changes ensures that such a header is parsed, that
it is handled correctly.

This was noticed when parsing the following header for websockets:
Sec-WebSocket-Extensions: permessage-deflate; client_no_context_takeover;
client_max_window_bits; server_no_context_takeover

It was parsing with the value permessage-deflate (correct) with parameters:
{'client_no_context_takeover;' : 'client_max_window_bits', 
'server_no_context_takeover' : null }

With this patch it now properly shows the parameters as:
{'client_no_context_takeover' : null, 
'client_max_window_bits' : null,
'server_no_context_takeover' : null }

I've also included a test for this as well.

BUG=

Patch by Matthew Butler <butler.matthew@gmail.com>.
==========

to

==========
HeaderValues: Handle all parameters without values.

Some cases, an HttpHeader Value may contain all parameters and
no values. This changes ensures that such a header is parsed, that
it is handled correctly.

This was noticed when parsing the following header for websockets:
Sec-WebSocket-Extensions: permessage-deflate; client_no_context_takeover;
client_max_window_bits; server_no_context_takeover

It was parsing with the value permessage-deflate (correct) with parameters:
{'client_no_context_takeover;' : 'client_max_window_bits', 
'server_no_context_takeover' : null }

With this patch it now properly shows the parameters as:
{'client_no_context_takeover' : null, 
'client_max_window_bits' : null,
'server_no_context_takeover' : null }

I've also included a test for this as well.

BUG=

Patch by Matthew Butler <butler.matthew@gmail.com>.

Committed:
https://github.com/dart-lang/sdk/commit/eaf75a100e8fe547c3ad60f8618f15fbf6a3a9dc
==========

[Søren Gjesse, 2016-01-07 08:04:02]

Committed patchset #1 (id:1) manually as
eaf75a100e8fe547c3ad60f8618f15fbf6a3a9dc (presubmit successful).

[Søren Gjesse, 2016-01-07 08:04:15]

LGTM, thanks.