Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 15649018: Call crypto::InitializeTPMToken on the IO thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index a5abbd1621b2192ea4ca82a2c5324ae37124d180..ef8a25cf45093e9d8602ddfb897ecda54a9b5fb2 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -304,7 +304,9 @@ class DBusServices {
// Always initialize these handlers which should not conflict with
// NetworkLibrary.
- NetworkHandler::Initialize();
+ NetworkHandler::Initialize(
+ content::BrowserThread::GetMessageLoopProxyForThread(
+ content::BrowserThread::IO));
CertLibrary::Initialize();
// Initialize the network change notifier for Chrome OS. The network
@@ -835,6 +837,10 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() {
// trigger MergeSessionThrottle::ShouldShowMergeSessionPage, which requires
// the UserManager to exist.
UserManager::Destroy();
+
+ // Destroy DBus services after g_borowser_process and Ash are destroyed
Ryan Sleevi 2013/06/06 23:03:41 s/borowser_process/browser_process/
stevenjb 2013/06/07 02:37:47 Done.
+ // and before destroying threads.
+ dbus_services_.reset();
Ryan Sleevi 2013/06/06 23:03:41 THREADING: The Chaps token implicitly relies on DB
stevenjb 2013/06/07 02:37:47 Does "The Chaps token" use DBusThreadManager? Can
Ryan Sleevi 2013/06/07 23:12:43 No clue. From the view of the network stack, the C
stevenjb 2013/06/08 02:06:50 OK, cool, we should be fine then either way.
}
void ChromeBrowserMainPartsChromeos::PostDestroyThreads() {

Powered by Google App Engine
This is Rietveld 408576698