Attempt to fix use-after-free in VersionUpdaterWin.

Attempt to fix use-after-free in VersionUpdaterWin.

I've been unable to repro the crash, but perhaps there's a way for
VersionUpdaterWin::OnReportResults to be invoked twice. This change
detaches the VersionUpdaterWin instance from the GoogleUpdate instance
when it releases its reference.

BUG=236413, 242895
R=mad@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202707

[MAD, 2013-05-28 19:37:06]

LGTM with one request...

Thanks!

BYE
MAD

https://codereview.chromium.org/15649007/diff/1002/chrome/browser/ui/webui/he...
File chrome/browser/ui/webui/help/version_updater_win.cc (right):

https://codereview.chromium.org/15649007/diff/1002/chrome/browser/ui/webui/he...
chrome/browser/ui/webui/help/version_updater_win.cc:261: void
VersionUpdaterWin::SetGoogleUpdater() {
While you are there, maybe we should rename this to ResetGoogleUpdater.

Or maybe we should move in here the DCHECK that is done before calling this
method at one point. Because this method is only called when google_updater_ is
actually NULL or DCHECK'd to be NULL.

[grt (UTC plus 2), 2013-05-28 19:49:08]

Thanks.

+estade for OWNERS review.

https://codereview.chromium.org/15649007/diff/1002/chrome/browser/ui/webui/he...
File chrome/browser/ui/webui/help/version_updater_win.cc (right):

https://codereview.chromium.org/15649007/diff/1002/chrome/browser/ui/webui/he...
chrome/browser/ui/webui/help/version_updater_win.cc:261: void
VersionUpdaterWin::SetGoogleUpdater() {
On 2013/05/28 19:37:06, MAD wrote:
> While you are there, maybe we should rename this to ResetGoogleUpdater.

Nice idea. I went for "CreateGoogleUpdater". SGTY?

> Or maybe we should move in here the DCHECK that is done before calling this
> method at one point. Because this method is only called when google_updater_
is
> actually NULL or DCHECK'd to be NULL.

I prefer leaving it as-is so that this method is safe to be called at any time.
The caller(s) can DCHECK that the world is as they expect it when they make the
call.

[MAD, 2013-05-28 20:31:00]

Cool, thanks, agreed, still LGTM!

BYE
MAD

[Evan Stade, 2013-05-28 21:24:22]

lgtm

[commit-bot: I haz the power, 2013-05-28 22:30:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/15649007/6002

[commit-bot: I haz the power, 2013-05-29 00:27:00]

Change committed as 202707