Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1564863002: Get rid of AXScrollView and AXScrollbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dump_oopif_3
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 128f2a560e06136594efc245f24e4ac3f0bb68c6..8bd4e2aaaca9bf8e7d51ec1b54cf7c2ec0bb7dd1 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -242,10 +242,8 @@ void FrameView::forAllNonThrottledFrameViews(Function function)
void FrameView::removeFromAXObjectCache()
{
- if (AXObjectCache* cache = axObjectCache()) {
- cache->remove(this);
+ if (AXObjectCache* cache = axObjectCache())
cache->childrenChanged(m_frame->pagePopupOwner());
- }
}
void FrameView::init()
@@ -2986,8 +2984,6 @@ void FrameView::setLayoutSizeInternal(const IntSize& size)
void FrameView::didAddScrollbar(Scrollbar& scrollbar, ScrollbarOrientation orientation)
{
ScrollableArea::didAddScrollbar(scrollbar, orientation);
- if (AXObjectCache* cache = axObjectCache())
- cache->handleScrollbarUpdate(this);
}
void FrameView::setTopControlsViewportAdjustment(float adjustment)
@@ -3025,8 +3021,6 @@ void FrameView::setHasHorizontalScrollbar(bool hasBar)
m_horizontalScrollbar->styleChanged();
} else {
willRemoveScrollbar(*m_horizontalScrollbar, HorizontalScrollbar);
- if (AXObjectCache* cache = axObjectCache())
- cache->remove(m_horizontalScrollbar.get());
// If the scrollbar has been marked as overlapping the window resizer,
// then its removal should reduce the count.
if (m_horizontalScrollbar->overlapsResizer())
@@ -3034,8 +3028,6 @@ void FrameView::setHasHorizontalScrollbar(bool hasBar)
removeChild(m_horizontalScrollbar.get());
m_horizontalScrollbar->disconnectFromScrollableArea();
m_horizontalScrollbar = nullptr;
- if (AXObjectCache* cache = axObjectCache())
- cache->handleScrollbarUpdate(this);
}
setScrollCornerNeedsPaintInvalidation();
@@ -3053,8 +3045,6 @@ void FrameView::setHasVerticalScrollbar(bool hasBar)
m_verticalScrollbar->styleChanged();
} else {
willRemoveScrollbar(*m_verticalScrollbar, VerticalScrollbar);
- if (AXObjectCache* cache = axObjectCache())
- cache->remove(m_verticalScrollbar.get());
// If the scrollbar has been marked as overlapping the window resizer,
// then its removal should reduce the count.
if (m_verticalScrollbar->overlapsResizer())
@@ -3062,8 +3052,6 @@ void FrameView::setHasVerticalScrollbar(bool hasBar)
removeChild(m_verticalScrollbar.get());
m_verticalScrollbar->disconnectFromScrollableArea();
m_verticalScrollbar = nullptr;
- if (AXObjectCache* cache = axObjectCache())
- cache->handleScrollbarUpdate(this);
}
setScrollCornerNeedsPaintInvalidation();

Powered by Google App Engine
This is Rietveld 408576698