Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1564853002: cmake: set SK_RELEASE to 0 if not a Release build (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
Marco A., mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

cmake: set SK_RELEASE to 0 if not a Release build BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1564853002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/95bc09b666c7872386a4ec57e8147f474f5ad03a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cmake/CMakeLists.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mtklein_C
4 years, 11 months ago (2016-01-06 18:13:56 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564853002/1
4 years, 11 months ago (2016-01-06 18:14:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 18:35:57 UTC) #7
Marco A.
On 2016/01/06 18:35:57, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 11 months ago (2016-01-07 09:28:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564853002/1
4 years, 11 months ago (2016-01-07 14:54:01 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 14:56:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/95bc09b666c7872386a4ec57e8147f474f5ad03a

Powered by Google App Engine
This is Rietveld 408576698