Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1564843002: Fix some SkCodecPrintfs (Closed)

Created:
4 years, 11 months ago by scroggo
Modified:
4 years, 11 months ago
Reviewers:
msarett, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix some SkCodecPrintfs Silence the warning about peeking. Until we implement peeking for the stream often used, it will always print, cluttering the logs. Add some more information to the warning about failing to rewind. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1564843002 Committed: https://skia.googlesource.com/skia/+/3ab9f2ede415438699594915386961df5215f9d7

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/codec/SkCodec.cpp View 1 chunk +5 lines, -2 lines 2 comments Download

Messages

Total messages: 12 (6 generated)
scroggo
https://codereview.chromium.org/1564843002/diff/1/src/codec/SkCodec.cpp File src/codec/SkCodec.cpp (right): https://codereview.chromium.org/1564843002/diff/1/src/codec/SkCodec.cpp#newcode74 src/codec/SkCodec.cpp:74: SkCodecPrintf("Encoded image data could not peek or rewind to ...
4 years, 11 months ago (2016-01-06 16:57:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564843002/1
4 years, 11 months ago (2016-01-06 16:58:10 UTC) #5
msarett
LGTM Would prefer to land this instead of: https://codereview.chromium.org/1565823002/ https://codereview.chromium.org/1564843002/diff/1/src/codec/SkCodec.cpp File src/codec/SkCodec.cpp (right): https://codereview.chromium.org/1564843002/diff/1/src/codec/SkCodec.cpp#newcode74 src/codec/SkCodec.cpp:74: ...
4 years, 11 months ago (2016-01-06 17:11:27 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 17:17:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564843002/1
4 years, 11 months ago (2016-01-06 17:52:58 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 17:53:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3ab9f2ede415438699594915386961df5215f9d7

Powered by Google App Engine
This is Rietveld 408576698