Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: tests/compiler/dart2js/diagnostic_helper.dart

Issue 1564803002: Specialize message for parts as entry point (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/diagnostic_helper.dart
diff --git a/tests/compiler/dart2js/diagnostic_helper.dart b/tests/compiler/dart2js/diagnostic_helper.dart
index 2fbdfcd563d4860698b6ffc3f14265fc31885fad..26dac3070aecea205577bf2aec3692dc2c281604 100644
--- a/tests/compiler/dart2js/diagnostic_helper.dart
+++ b/tests/compiler/dart2js/diagnostic_helper.dart
@@ -27,7 +27,10 @@ class CollectedMessage {
MessageKind get messageKind => message.kind;
- String toString() => '${message.kind}:$uri:$begin:$end:$text:$kind';
+ String toString() {
+ return '${message != null ? message.kind : ''}'
+ ':$uri:$begin:$end:$text:$kind';
+ }
}
class DiagnosticCollector implements CompilerDiagnostics {
@@ -77,6 +80,48 @@ class DiagnosticCollector implements CompilerDiagnostics {
void clear() {
messages.clear();
}
+
+ void checkMessages(List<Expected> expectedMessages) {
+ int index = 0;
+ Iterable<CollectedMessage> messages =
+ filterMessagesByKinds(
+ [Diagnostic.ERROR,
+ Diagnostic.WARNING,
+ Diagnostic.HINT,
+ Diagnostic.INFO]);
+ for (CollectedMessage message in messages) {
+ if (index >= expectedMessages.length) {
+ Expect.fail("Unexpected messages:\n "
+ "${messages.skip(index).join('\n ')}");
+ } else {
+ Expected expected = expectedMessages[index];
+ Expect.equals(expected.messageKind, message.messageKind,
+ "Unexpected message kind in:\n ${messages.join('\n ')}");
+ Expect.equals(expected.diagnosticKind, message.kind,
+ "Unexpected diagnostic kind in\n ${messages.join('\n ')}");
+ index++;
+ }
+ }
+ }
+}
+
+class Expected {
+ final MessageKind messageKind;
+ final Diagnostic diagnosticKind;
+
+ const Expected(this.messageKind, this.diagnosticKind);
+
+ const Expected.error(MessageKind messageKind)
+ : this(messageKind, Diagnostic.ERROR);
+
+ const Expected.warning(MessageKind messageKind)
+ : this(messageKind, Diagnostic.WARNING);
+
+ const Expected.hint(MessageKind messageKind)
+ : this(messageKind, Diagnostic.HINT);
+
+ const Expected.info(MessageKind messageKind)
+ : this(messageKind, Diagnostic.INFO);
}

Powered by Google App Engine
This is Rietveld 408576698